Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 300908 - motion ebuild has bogus dependency on virtual/postgresql-server
Summary: motion ebuild has bogus dependency on virtual/postgresql-server
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-13 21:21 UTC by michael higgins
Modified: 2010-01-26 20:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description michael higgins 2010-01-13 21:21:19 UTC
motion ebuild has bogus dependency on virtual/postgresql-server:

--- /media/portage/media-video/motion/motion-3.2.11.1.ebuild	2009-10-23 06:12:49.000000000 -0700
+++ motion-3.2.11.1-r1.ebuild	2010-01-13 12:06:39.649788587 -0800
@@ -18,7 +18,7 @@
 	media-libs/jpeg
 	ffmpeg? ( media-video/ffmpeg )
 	mysql? ( virtual/mysql )
-	postgres? ( virtual/postgresql-server )"
+	postgres? ( virtual/postgresql-base )"
 DEPEND="${RDEPEND}"
 
 pkg_setup() {

Reproducible: Always

Steps to Reproduce:
1. emerge motion with postgres use flag enabled
2. wonder why (tf) something is pulling in postgresql-server when it isn't needed
Actual Results:  
Pulls in new package postgresql-server, which is not needed.

Expected Results:  

With patch as above,

. . .

checking for mysql support... skipped
checking for PostgreSQL... testing
checking autodect pgsql headers... yes /usr/include
checking autodect pgsql libs... /usr/lib
checking for PQconnectStart in -lpq... yes

. . . 

   *******************************
      Configure status    
      motion "3.2.11.1"
   *******************************

OS             :     Linux
pthread Support:     Yes
jpeg Support:        Yes
V4L included:        Yes
V4L2 supported:      Yes
FFmpeg Support:      Yes
MYSQL Support:       No
PostgreSQL Support:  Yes

Note that we still found the needed libraries....

Libs for building clients are pulled in with virtual/postgresql-base, so maybe this would be a good thing to check overall. Rarely (never?) is a database server required on the same machine you are running a client application... I mention this only because IDK if this is entirely clear to whoever wrote this ebuild, or if it bears looking into further.

Regarding the last point:

find /media/portage/ -name '*.ebuild' -print |while read ebuild ; do grep -l 'virtual/postgresql-server' $ebuild ; done |wc -l --> 124 ebuilds to check... IMO
Comment 1 Patrick Lauer gentoo-dev 2010-01-26 20:28:27 UTC
+  26 Jan 2010; Patrick Lauer <patrick@gentoo.org> motion-3.2.11.1.ebuild:
+  Fixing postgres dep for #300908
+