Bug 300634 – net-im/pyotr change Name to net-im/python-otr

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Hans Meier 2010-01-11 22:13:01 UTC]

Look at

http://www.cypherpunks.ca/otr/

http://python-otr.pentabarf.de/

http://python-otr.pentabarf.de/download.html


This is old Version

net-im/pyotr-0.1


This is new Version

net-im/python-otr-0.2.1.1

Please correct Package Name


Please add this Package to Gentoo

http://gajim-otr.pentabarf.de/

[Comment 1 Hans Meier 2010-01-11 22:14:01 UTC]

Created attachment 216133 [details]
python-otr-0.2.1.1.ebuild

[Comment 2 Peter Volkov (RETIRED) 2010-01-12 07:21:50 UTC]

Hans, although I know you took ebuild from the tree, here is a few comments on how to improve it: It's better to use python_get_sitedir() to get path where to install otr.py. Also there should be || die after doinst, explicitly define RDEPEND. And finally since otr.py is installed manually shouldn't python_mod_optimize/python_mod_cleanup to be called in pkg_postinst/pkg_postrm?

BTW, it's good idea to attach diff against pyotr-0.1.ebuild too (or only diff) since then it's much easier to review changes.

Thanks for this bug report.

[Comment 3 Hans Meier 2010-01-12 12:40:45 UTC]

Thanks I have only renamed ebuild and Package accordly to

http://python-otr.pentabarf.de/

I am not programmer but made this new python-otr-0.2.1.1.ebuild with Yours proposals

[Comment 4 Hans Meier 2010-01-12 12:42:00 UTC]

Created attachment 216219 [details]
new ebuild for python-otr-0.2.1.1.ebuild

diff pyotr-0.1.ebuild python-otr-0.2.1.1.ebuild
16a17,18
> RDEPEND="${DEPEND}
>         >=net-libs/libotr-3.2.0"
23a26,28
> pkg_postrm() {
>         python_mod_cleanup /usr/$(get_libdir)/python*/site-packages/${PN}
> }

[Comment 5 Hanno Böck 2010-01-13 18:03:25 UTC]

Hi, the whole insinto/doins-stuff is not needed any longer. Also, your RDEPEND-changes don't make much sense.

Anyway, moved pyotr to python-otr and committed 0.2.1.1 ebuild.