Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299936 - net-libs/libnfnetlink needs better linux-info.eclass handling
Summary: net-libs/libnfnetlink needs better linux-info.eclass handling
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 19:33 UTC by Kobboi
Modified: 2010-01-10 09:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2010-01-06 19:33:42 UTC
The ebuild wants to check the kernel configuration, which may possibly be included in the package providing virtual/linux-sources. In that case, adding the dependency will pull in the sources+config before trying to do the check.

Reproducible: Always
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-01-06 19:45:42 UTC
libnfnetlink has inherit linux-info

linux-info.eclass has:
[ -z "${I_KNOW_WHAT_I_AM_DOING}" ] && \
DEPEND="kernel_linux? ( virtual/linux-sources )"

So, this bug report is for something that is already being done.


Comment 2 Kobboi 2010-01-07 09:56:15 UTC
(In reply to comment #1)
> libnfnetlink has inherit linux-info
> 
> linux-info.eclass has:
> [ -z "${I_KNOW_WHAT_I_AM_DOING}" ] && \
> DEPEND="kernel_linux? ( virtual/linux-sources )"
> 
> So, this bug report is for something that is already being done.
> 

Correct. I just noticed that emerging libnfnetlink does pull in my kernel package. 

The issue is that the kernel config check is done in pkg_setup(), which is also executed for binary packages, but virtual/linux-sources is in DEPEND, so my kernel package (including a .config and compilation in src_compile) is not pulled in.
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-01-07 14:20:13 UTC
(In reply to comment #2)

> Correct. I just noticed that emerging libnfnetlink does pull in my kernel
> package. 
> 
> The issue is that the kernel config check is done in pkg_setup(), which is also
> executed for binary packages, but virtual/linux-sources is in DEPEND, so my
> kernel package (including a .config and compilation in src_compile) is not
> pulled in.
> 

Ah yes, I see what you mean. Thanks for explaining. Basically, the ebuild is not compatible with binary packages. I faced similar issues when I filed bug 296578, maybe you can use that as inspiration.
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-01-10 09:18:08 UTC
per bug 283320, we no longer bring in linux-sources since rev 1.79 of the eclass.