Bug 299772 – gnome2.eclass should filter all -O? different than -O2

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Pacho Ramos 2010-01-05 14:38:55 UTC]

After checking bug 276549 and http://www.gentoo.org/proj/en/desktop/gnome/gnome-policy.xml#doc_chap2 , I think that would be interesting to try to force all gnome related ebuilds to build with -O2 instead of -O3, -Os...

The idea would be to modify gnome2.eclass from:
gnome2_src_compile() {
        has ${EAPI:-0} 0 1 && gnome2_src_configure "$@"
        emake || die "compile failure"
}

to something like (after inheriting flag-o-matic eclass of course ;-)):
gnome2_src_compile() {
        replace-flags -O? -O2
        has ${EAPI:-0} 0 1 && gnome2_src_configure "$@"
        emake || die "compile failure"
}

Best regards

Reproducible: Always

[Comment 1 Samuli Suominen (RETIRED) 2010-01-05 14:44:59 UTC]

Absolutely NOT.

[Comment 2 Samuli Suominen (RETIRED) 2010-01-05 15:06:07 UTC]

Created attachment 215301 [details]
Ebuilds using gnome2.eclass

It's not only gnome that's using gnome2.eclass. 
It would also break all debugging with -O0, -O1.

[Comment 3 Nirbheek Chauhan (RETIRED) 2010-01-05 16:04:42 UTC]

I agree. Flag-filtering has already been discussed extensively. Specific flags which do not work need to be disabled per-ebuild; never in such a widely-used eclass like gnome2.eclass

[Comment 4 Mark Loeser (RETIRED) 2010-01-05 16:16:33 UTC]

And please let toolchain know when you are filtering a flag...because you are merely ignoring a bug in gcc when you filter it :)

[Comment 5 Gilles Dartiguelongue (RETIRED) 2010-01-05 16:17:58 UTC]

Just for the sake of it, I'll add that even if we constantly repeat that gnome herd and upstream do not support anything greater than -O2 it doesn't mean we will not look into bugs failing to meet this requirement and/or handover to gcc herd for further analysis.

[Comment 6 Pacho Ramos 2010-01-05 17:16:49 UTC]

OK, thanks a lot for the information :-)