Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299680 - dev-python/pygobject: Makefile.am sets $TMPDIR, disrupting distcc
Summary: dev-python/pygobject: Makefile.am sets $TMPDIR, disrupting distcc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-04 23:28 UTC by Kevin Pyle
Modified: 2010-03-19 17:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rename TMPDIR variable to something less dangerous (pygobject-2.20.0.ebuild_patch,415 bytes, patch)
2010-03-08 14:40 UTC, Greg Turner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pyle 2010-01-04 23:28:55 UTC
As first reported in $URL, dev-python/pygobject has a top level Makefile.am that overwrites TMPDIR with a value that is not an absolute path.  As a result, distcc fails to find a usable temporary directory, and reverts to compiling locally.  I submitted a patch to upstream, which was committed and can be viewed at <http://git.gnome.org/browse/pygobject/commit/?id=4e2efa91d101bf755739e1cca8eee41eb0ad20fd>.  Please consider applying this patch to existing Gentoo ebuilds.  Since the problem does not impact the installed code, no revision bump is needed.
Comment 1 Greg Turner 2010-03-08 14:36:23 UTC
This also causes compilation to fail on Interix (gentoo prefix), where settinng TMPDIR to anything but a Windows-style "C:\whatever" file-path is disastrous.
Comment 2 Greg Turner 2010-03-08 14:40:18 UTC
Created attachment 222669 [details, diff]
rename TMPDIR variable to something less dangerous

This patch will fix the problem until the patch trickles down from upstream.  Even if this code were accidentally left in portage thereafter, it would harmlessly rename EGG_TMPDIR to EGG_EGG_TMPDIR.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-03-08 15:36:09 UTC
I'd rather have a Makefile.am patch. I'll try to look at this tonight.
Comment 4 Kevin Pyle 2010-03-09 04:02:43 UTC
(In reply to comment #3)
> I'd rather have a Makefile.am patch. I'll try to look at this tonight.

Do you mean you would prefer a .patch file over a change made with sed?  Such a patch was committed upstream, and is linked in comment #0.  The 'patch' link in the resulting Git view CGI <http://git.gnome.org/browse/pygobject/patch/?id=4e2efa91d101bf755739e1cca8eee41eb0ad20fd> will generate a patch that should be suitable for application via epatch.
Comment 5 Pacho Ramos gentoo-dev 2010-03-19 17:04:56 UTC
Just fixed in 2.20.0 without a bump, thanks to the report and the patch