Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299620 - dev-libs/botan (dependency of monotone) for the prefixed portage
Summary: dev-libs/botan (dependency of monotone) for the prefixed portage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All OS X
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-04 15:42 UTC by Dirk Tilger
Modified: 2010-01-23 19:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against an eprefixified botan ebuild (botan-1.8.8.ebuild.patch,2.00 KB, patch)
2010-01-04 15:53 UTC, Dirk Tilger
Details | Diff
Patch required to be in the ${FILESDIR} for the earlier attached ebuild to work. (botan-1.8.8-install_name.patch,647 bytes, patch)
2010-01-04 15:56 UTC, Dirk Tilger
Details | Diff
Updated patch against the eprefixified botan ebuild (botan-1.8.8.ebuild.patch,2.26 KB, patch)
2010-01-05 12:44 UTC, Dirk Tilger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Tilger 2010-01-04 15:42:08 UTC
This is a first attempt to bring botan to the prefixed portage. Tested on MacOSX 10.4 only.

Botan is a dependency of monotone, which is the source code repository software for pidgin and libpurple (which in turn is used by the MacOSX software Adium).
Comment 1 Dirk Tilger 2010-01-04 15:53:37 UTC
Created attachment 215176 [details, diff]
Patch against an eprefixified botan ebuild

The OS detection I've copied from perl-5.10.1.ebuild, because with...
 find ${EPREFIX}/usr/portage -name '*.ebuild' | xargs grep darwin | grep -v CHOST
... I could not find an OS detection function. But the pure amount of CHOST usages really speak for having one. botan seems to support a number of operating systems (solaris as well) according to the build script, but I didn't limit the section in the ebuild to those in the hope more OS will be supported in the future.

The modification of the final mv comes from the fact that HFS+ is case-insensitive and...
mv Botan-1.8.8 botan-1.8.8
... thus makes the 'mv' attempt to...
mv botan-1.8.8 botan-1.8.8/botan-1.8.8
Comment 2 Dirk Tilger 2010-01-04 15:56:04 UTC
Created attachment 215178 [details, diff]
Patch required to be in the ${FILESDIR} for the earlier attached ebuild to work.

Botan uses a custom make system which does not distinguish PREFIX and DESTDIR, thus -install_name needs some manual treatment. The ${P}-install_name.patch is therefore not upstream-compatible, since PREFIX cannot be determined straight forward.
Comment 3 Dirk Tilger 2010-01-04 16:48:00 UTC
Sorry, I just noticed the ebuild should inherit prefix. I have no idea why it worked for me without eprefixify being available.
Comment 4 Dirk Tilger 2010-01-05 12:44:05 UTC
Created attachment 215279 [details, diff]
Updated patch against the eprefixified botan ebuild

Updated attachment 215176 [details, diff]
- botan.pc and botan-config were stripped off the $EPREFIX
- ebuild should inherit prefix (has been implicitely done before through toolchain-funcs
Comment 5 Fabian Groffen gentoo-dev 2010-01-23 15:18:52 UTC
I fixed this by basically injecting the right arguments at the right time to fix all issues (install_name, install location, ${D} in pkgconfig/botan-config script).
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-01-23 19:20:24 UTC
In the future, please CC maintainers if you are discussing suggested changes for ebuilds in gentoo-x86.