Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299540 - repoman should check for wrong !use syntax
Summary: repoman should check for wrong !use syntax
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-04 02:54 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2022-07-12 03:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-01-04 02:54:35 UTC
I found a couple of packages (and I made that mistake myself before) that use !use instead of ! use when checking for a disabled USE flag.

Since this is a likely easy to spot mistake, maybe repoman should be looking for that before commit.
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-01-05 14:54:53 UTC
Could you provide specific examples?
Comment 2 Kevin Pyle 2010-01-05 17:59:25 UTC
If I understand the description in comment #0 correctly, then you can find examples by running:

find /usr/portage/ \( -name '*.ebuild' -o -name '*.eclass' 
\) -print0 | xargs -0 grep -Hn '!use\>'

This would seem to be confirmed by a change Diego made to media-sound/pulseaudo-0.9.17.ebuild in September 2009, with the commit message "Fix !use missing whitespace."  For the tree on my system, the only package so flagged now is net-mail/dbmail:

if !use postgres && !use mysql && !use sqlite3; then myconf="${myconf} --with-sqlite" ; fi
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:27 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.