Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 298932 - app-misc/gnote: correct dependency for applet use flag
Summary: app-misc/gnote: correct dependency for applet use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gilles Dartiguelongue (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-30 01:48 UTC by Olaf Leidinger
Modified: 2010-03-08 23:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Leidinger 2009-12-30 01:48:49 UTC
In contrast to the dependency coded in the ebuild, gnote can be built without dependency on gnome when using -applet.

--- gnote-0.6.3.ebuild	2009-12-30 02:46:12.602999177 +0100
+++ gnote-0.6.3.ebuild-fixed	2009-12-30 02:45:47.499001733 +0100
@@ -24,8 +24,7 @@
 	>=app-text/gtkspell-2.0.9
 	>=dev-libs/boost-1.34
 	sys-libs/e2fsprogs-libs
-	>=gnome-base/gnome-panel-2
-	applet? ( >=dev-cpp/libpanelappletmm-2.26 )"
+	applet? ( >=dev-cpp/libpanelappletmm-2.26 >=gnome-base/gnome-panel-2 )"
 # Build with dbus is currently not implemented
 #	dbus? ( >=dev-libs/dbus-glib-0.70 )"
 DEPEND="${DEPEND}


I don't know if it is possible, but maybe one could introduce another use flag "gnome", which disables "applet" when not set.

Reproducible: Always
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-12-30 12:52:16 UTC
one use flag to control this feature is enough. There is a couple of other package using the same USE for the same functionality and as such it won't be changed. As for the gnome-panel dependency, it is unnecessary as libpanelappletmm already DEPENDs on it and runtime could be something else than gnome-panel as long as it's implementing the same API.
Comment 2 Olaf Leidinger 2009-12-30 13:25:37 UTC
In that case this bug is fixed for me, when the dependency on >=gnome-base/gnome-panel-2 is completely removed.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-12-31 10:48:00 UTC
alright, I misread the diff. I'll fix it asap.
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-03-08 23:55:49 UTC
  23 Feb 2010; Gilles Dartiguelongue <eva@gentoo.org> -gnote-0.6.2.ebuild,
  gnote-0.6.3.ebuild, gnote-0.7.1.ebuild:
  gnome-panel dependency is optional, bug #298932, thanks to Olaf for
  noticing.