Looking at the build.log, I think it would be nice to address some of the compiler warnings, mostly two groups of them: interface.c:*: warning: integer constant is too large for ‘long’ type (this one (on x86) comes from too thorough 0010-revert-621a2f37633~ee5783e0f1141e66d-for-.patch - those 'ull' should have stay there) In function ‘strncat’, inlined from ‘*_do_one’ at netstat.c:*: /usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might overflow destination buff (AFAICT, from technical POV those warnings are correct - size parameter should probably be something like 128-strlen(local_addr)-1 - this time it's 0007-prevent-overflows-in-interface-buffers.patch)
..or more correctly 'sizeof(local_addr)-strlen(local_addr)-1'
feel free to post actual patches instead of asking others to fix these things. they are pretty harmless last i looked.
Created attachment 214611 [details, diff] first of the corrected patches SpanKY, while what you say is true (to a point), do note that both of those patches are yours and seem to be Gentoo-only, as I don't see them on BerliOS. The corrected patches work, if they replace their old versions in patches tarball.
Created attachment 214613 [details, diff] second corrected patch
Note, that while 0010 is cosmetic only, old 0007 didn't prevent that overflow (that value would work for strncpy, not strncat, also according to manpage strncat already adds that '\0' at the end of the string)
it isnt "cosmetic". perhaps if you read up on the history, you'd know that changing the output breaks packages and people's scripts. further, you'd know that the strncat isnt Gentoo-specific, nor did i have anything to do with its creation. but i guess it's easier to just blame people then figure out the real history. ive updated the patches in the overlay
I was going by "From:" line in those git patches. On a semi-related note: I think we're beginning to agree, that we mutually dislike each other.
