Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 298605 - repoman commit should test if gpg is ready to sign manifest
Summary: repoman commit should test if gpg is ready to sign manifest
Status: RESOLVED OBSOLETE
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
: 360459 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-28 00:49 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2017-03-15 22:49 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-12-28 00:49:16 UTC
Right now it's very well possible that a broken gpg-agent, an expired signing key, or a password forgotten to be typed in due time will make the FEATURES=sign moot, since the commit is completed _before_ the signing take place.

To avoid this, it should probably be better to sign something _before_ commit, and fail if it didn't work properly.
Comment 1 Zac Medico gentoo-dev 2013-06-23 20:59:12 UTC
It seems that we can start a gpg process with our PORTAGE_GPG_SIGNING_COMMAND and omit the ${FILE} argument. The process will load the key into memory, and wait for us to feed it the Manifest on stdin. So, if the gpg process doesn't exit before we are ready to commit, then that should be enough to validate that it's safe to commit. When ready to sign, we just feed the Manifest to stdin and read the signed Manifest from stdout. Thanks for the suggestion from here:

  http://article.gmane.org/gmane.linux.gentoo.devel/86418
Comment 2 Jan Matějka (RETIRED) gentoo-dev 2013-06-27 19:06:08 UTC
*** Bug 360459 has been marked as a duplicate of this bug. ***
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2017-03-15 22:49:11 UTC
Since this is a CVS specific commit problem and we have moved on to a git based repository...

I am going to close this