Bug 298449 – dev-php5/pecl-ssh2-0.11 fails to build

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Peter Volkov (RETIRED) 2009-12-26 16:07:53 UTC]

Fedora patch breaks build with currently stable and in tree php:

libtool: compile:  x86_64-pc-linux-gnu-gcc -I. -I/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0 -DPHP_ATOM_INC -I/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/include -I/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/main -I/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0 -I/usr/lib64/php5/include/php -I/usr/lib64/php5/include/php/main -I/usr/lib64/php5/include/php/TSRM -I/usr/lib64/php5/include/php/Zend -I/usr/lib64/php5/include/php/ext -I/usr/lib64/php5/include/php/ext/date/lib -DHAVE_CONFIG_H -O2 -pipe -march=athlon64 -mtune=athlon64 -msse3 -fomit-frame-pointer -c /var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c  -fPIC -DPIC -o .libs/ssh2.o
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c: In function 'php_ssh2_set_callback':
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:260: error: too many arguments to function 'zend_is_callable'
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c: In function 'zif_ssh2_methods_negotiated':
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:503: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:504: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:508: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:509: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:510: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:511: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:516: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:517: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:518: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:519: warning: passing argument 4 of 'add_assoc_string_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c: In function 'zif_ssh2_fingerprint':
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:558: warning: initialization discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c: In function 'zif_ssh2_publickey_add':
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:1045: warning: passing argument 1 of '_efree' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c: In function 'zif_ssh2_publickey_list':
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:1104: warning: passing argument 4 of 'add_assoc_stringl_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:1105: warning: passing argument 4 of 'add_assoc_stringl_ex' discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:1113: warning: initialization discards qualifiers from pointer target type
/var/tmp/portage/dev-php5/pecl-ssh2-0.11.0/work/ssh2-0.11.0/ssh2.c:1114: warning: passing argument 2 of '_zend_hash_add_or_update' discards qualifiers from pointer target type
make: *** [ssh2.lo] Error 1

[Comment 1 Peter Volkov (RETIRED) 2009-12-26 16:16:50 UTC]

Created attachment 214215 [details, diff]
pecl-ssh2-0.11.0-php-5.3-compat.patch

Updated patch to work with 5.2 too.

[Comment 2 Christian Hoffmann (RETIRED) 2009-12-27 23:21:11 UTC]

Crap. I only did this change because I tested it with php-5.2. Apparently the build failure only manifests itself with dev-lang/php[threads].

I have reverted the change, so that stable continues working and php-5.3 needs fixing again.
The patch you attached sadly does not work as expected, I more or less had one exactly like that. I can think of a solution though.

[Comment 3 Christian Hoffmann (RETIRED) 2009-12-30 01:09:58 UTC]

Can someone please retest with -r1? It should work with both php-5.2 and php-5.3.