Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 2981 - dyn_compile doesn't check return value of src_compile
Summary: dyn_compile doesn't check return value of src_compile
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Daniel Robbins (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-24 02:37 UTC by Ryan Shaw
Modified: 2011-10-30 22:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Shaw 2002-05-24 02:37:35 UTC 
the default src_compile() returns 1 if it fails:

src_compile() { 
        if [ -x ./configure ] ; then
	        econf || return 1
		emake || return 1
	fi
	return 
}

but dyn_compile() is not checking the return 
value. this means that ebuilds cannot safely
use the default src_compile() function.
Comment 1 Daniel Robbins (RETIRED) gentoo-dev 2002-06-27 23:34:40 UTC 
these should be changed to || die.  Will do soon.
Comment 2 Daniel Robbins (RETIRED) gentoo-dev 2002-08-04 23:56:53 UTC 
fix in Portage 2.0.24.  Thanks for your patience.