Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 29799 - patch to make Mozilla compile on amd64
Summary: patch to make Mozilla compile on amd64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High major (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 29804
  Show dependency tree
 
Reported: 2003-09-28 06:59 UTC by Brad House
Modified: 2003-10-02 20:50 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
base patch derived from Mandrake's patchset (mozilla-1.4-amd64.patch,34.23 KB, patch)
2003-09-28 07:01 UTC, Brad House
Details | Diff
patch for ebuild (mozilla-1.4-r4.ebuild.amd64.patch,1.30 KB, patch)
2003-09-28 07:09 UTC, Brad House
Details | Diff
mozilla ebuild patch (mozilla-1.4-r4.ebuild.amd64.patch,1.73 KB, patch)
2003-09-30 10:16 UTC, Brad House
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brad House 2003-09-28 06:59:41 UTC
patchset derived from Mandrake amd64 patches.
Also includes ebuild patch against 1.4-r4 
Please note the requirement of the static C Flags.  Anything higher
causes Mozilla to segfault on startup.
Comment 1 Brad House 2003-09-28 07:01:56 UTC
Created attachment 18416 [details, diff]
base patch derived from Mandrake's patchset
Comment 2 Brad House 2003-09-28 07:09:50 UTC
Created attachment 18417 [details, diff]
patch for ebuild
Comment 3 Brad House 2003-09-28 10:54:24 UTC
assigned to wrong component ... oops
Comment 4 Olivier Crete (RETIRED) gentoo-dev 2003-09-29 07:38:50 UTC
only one thing.. maybe putting the CFLAGS in the optimise part is not right?...
 Appart from that, from my point of view it seems right.. 
Comment 5 Brad House 2003-09-29 07:50:01 UTC
Well, if you leave -O2 in there, mozilla refuses to start (or it does, then
immediately segfaults).  I guess I need to make another variable, then make
that arch-dependant, set it to -O -fPIC for amd64, and  -O2 for everything
else. I don't like the way it currently hardcodes -O2 in the optimize part
...
 
Comment 6 Brad House 2003-09-30 10:16:00 UTC
Created attachment 18545 [details, diff]
mozilla ebuild patch

This patch sets -O2 for enable optimize for all platforms
except amd64 ; amd64 uses the static CFLAGS we set for stability.
This should get rid of the concerns mentioned by Tester.
Comment 7 Olivier Crete (RETIRED) gentoo-dev 2003-10-02 03:03:40 UTC
latest patch seems ok to me.. if its ok for the mozilla ppl then can commit..
Comment 8 Brad House 2003-10-02 20:50:31 UTC
applied patches to cvs