Bug 296063 – dev-db/mysql-5.0.84-r1 on x86-solaris

• Status: RESOLVED UPSTREAM
• Product: Gentoo/Alt

[Description Daniel Vergien 2009-12-07 10:33:57 UTC]

To get mysql-5.0.84 to compile on solaris, sql/sql_show.cc needs a patch since there is no strsep in solaris.

[Comment 1 Daniel Vergien 2009-12-07 10:35:31 UTC]

Created attachment 212320 [details, diff]
mysql-5.0.84-r1.ebuild.patch

[Comment 2 Daniel Vergien 2009-12-07 10:35:49 UTC]

Created attachment 212322 [details, diff]
solaris-sql_show.patch

[Comment 3 Daniel Vergien 2009-12-07 10:37:07 UTC]

Created attachment 212324 [details, diff]
mysql-5.0.84-r1.ebuild.patch

[Comment 4 Fabian Groffen 2009-12-07 12:13:58 UTC]

What version of Solaris is this?  It doesn't fail to compile for me.

[Comment 5 Daniel Vergien 2009-12-09 17:42:50 UTC]

/etc/release says: Solaris 10 5/09 s10x_u7wos_08 X86

[Comment 6 Fabian Groffen 2009-12-12 18:06:35 UTC]

Looks like percona patches introduced this strsep requirement.  That explains a lot to me.  I couldn't imagine MySQL upstream doing that.

[Comment 7 Fabian Groffen 2009-12-12 18:47:56 UTC]

10030_all_userstatv2-percona-5.0.84-b18-20090811.patch to be exact

[Comment 8 Fabian Groffen 2009-12-12 19:51:11 UTC]

In all three cases it looks like a simple hack using strchr is able to replace strsep in this patch.

[Comment 9 Daniel Vergien 2009-12-25 11:35:42 UTC]

Replacing strsep with strchr lead to this:
sql_show.cc: In function 'int fill_schema_table_stats(THD*, TABLE_LIST*, COND*)':
sql_show.cc:2250: error: cannot convert 'char**' to 'const char*' for argument '1' to 'char* strchr(const char*, int)'
sql_show.cc: In function 'int fill_schema_index_stats(THD*, TABLE_LIST*, COND*)':
sql_show.cc:2293: error: cannot convert 'char**' to 'const char*' for argument '1' to 'char* strchr(const char*, int)'
sql_show.cc:2294: error: cannot convert 'char**' to 'const char*' for argument '1' to 'char* strchr(const char*, int)'

By the way, have you found a bugtracker at percona?

[Comment 10 Daniel Vergien 2010-02-21 08:06:07 UTC]

Created attachment 220571 [details, diff]
mysql-5.0.84-r1.ebuild.patch

Includes solaris-sql_show.patch only for solaris 2.10

[Comment 11 Fabian Groffen 2010-02-24 14:11:30 UTC]

is this superseeded by bug #306647 now?

[Comment 12 Daniel Vergien 2010-02-24 14:41:45 UTC]

Yes, I think we can close this here. At least I don't need 5.0.84 if I can have 5.0.90.

[Comment 13 Fabian Groffen 2010-02-24 14:43:14 UTC]

ok, cool