Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 295955 - vmware-modules-1.0.0.[24-r1,25] fails to compile on 2.6.32-gentoo
Summary: vmware-modules-1.0.0.[24-r1,25] fails to compile on 2.6.32-gentoo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Vadim Kuznetsov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-06 13:28 UTC by Doron Fediuck
Modified: 2010-01-03 14:13 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (build.log,9.56 KB, text/plain)
2009-12-06 13:30 UTC, Doron Fediuck
Details
Patch to make modules build agains linux 2.6.32 (vmware-modules-1.0.0.25.patch,1001 bytes, patch)
2009-12-07 01:21 UTC, Marc Schiffbauer
Details | Diff
ebuild for 1.0.0.24-r2 (vmware-modules-1.0.0.24-r2.ebuild,1.91 KB, text/plain)
2009-12-07 08:59 UTC, Doron Fediuck
Details
The patch for 1.0.0.24-r2. (vmware-modules-1.0.0.24-r2.patch,1.00 KB, patch)
2009-12-07 08:59 UTC, Doron Fediuck
Details | Diff
vmware-modules-1.0.0.25.ebuild (vmware-modules-1.0.0.25.ebuild,1.80 KB, patch)
2009-12-07 10:07 UTC, Florian
Details | Diff
Kernel configuration (kernel-config-x86_64-2.6.32-gentoo,67.25 KB, text/plain)
2009-12-09 15:42 UTC, Doron Fediuck
Details
emerge info (emerge.info,3.62 KB, text/plain)
2009-12-09 15:43 UTC, Doron Fediuck
Details
vmware-modules-1.0.0.25.patch-20631.out (vmware-modules-1.0.0.25.patch-20631.out,3.66 KB, text/plain)
2009-12-22 05:11 UTC, vvgloo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Doron Fediuck 2009-12-06 13:28:58 UTC
While trying to emerge, compilation fails.
Here's a snip:
/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/work/vmci-only/linux/vmciKernelIf.c:716: error: dereferencing pointer to incomplete type                                              
/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/work/vmci-only/linux/vmciKernelIf.c:716: error: ‘TASK_RUNNING’ undeclared (first use in this function)                                
make[3]: *** [/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/work/vmci-only/linux/vmciKernelIf.o] Error 1                                                                            
make[2]: *** [_module_/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/work/vmci-only] Error 2                                                                                         
make[1]: *** [sub-make] Error 2                                                                                                                                                              
make[1]: Leaving directory `/usr/src/linux-2.6.32-gentoo'                                                                                                                                    
make: *** [vmci.ko] Error 2                                                                                                                                                                  
 *                                                                                                                                                                                           
 * ERROR: app-emulation/vmware-modules-1.0.0.25 failed.
Comment 1 Doron Fediuck 2009-12-06 13:30:03 UTC
Created attachment 212225 [details]
Build log

Relevant build log.
Comment 2 Marc Schiffbauer gentoo-dev 2009-12-07 01:21:26 UTC
Created attachment 212288 [details, diff]
Patch to make modules build agains linux 2.6.32

I added the patch to the ebuild like this:

--- vmware-modules-1.0.0.25.ebuild      2009-09-25 13:06:53.000000000 +0200
+++ vmware-modules-1.0.0.25-r1.ebuild   2009-12-07 02:09:47.000000000 +0100
@@ -58,6 +58,7 @@
 src_prepare() {
        epatch "${FILESDIR}/${PV}-makefile-kernel-dir.patch"
        epatch "${FILESDIR}/${PV}-makefile-include.patch"
+       epatch "${FILESDIR}/patches/vmware-modules-1.0.0.25.patch"
 }

 src_install() {
Comment 3 Doron Fediuck 2009-12-07 08:59:01 UTC
Created attachment 212307 [details]
ebuild for 1.0.0.24-r2

Created an ebuild with a patch for 24, since vmware-server 2.0.2.203138 requires < vmware-modules-1.0.0.25. Attaching both. Thanks for the help. Can you add this to portage tree ?
Comment 4 Doron Fediuck 2009-12-07 08:59:42 UTC
Created attachment 212308 [details, diff]
The patch for 1.0.0.24-r2.
Comment 5 Robert Clark 2009-12-07 09:39:16 UTC
(In reply to comment #2)
> Created an attachment (id=212288) [details]
> Patch to make modules build agains linux 2.6.32

I tested this patch with my install and it got me past the compilation failure. Thanks.
Comment 6 Florian 2009-12-07 10:07:24 UTC
Created attachment 212312 [details, diff]
vmware-modules-1.0.0.25.ebuild

And here the modified ebuild.
Comment 7 Vadim Kuznetsov (RETIRED) gentoo-dev 2009-12-09 14:33:19 UTC
(In reply to comment #0)
> While trying to emerge, compilation fails.
> /vmciKernelIf.c:716:
> error: dereferencing pointer to incomplete type                                 

I can't reproduce this issue so far. Could you provide emerge info and kernel config, please?
Comment 8 Doron Fediuck 2009-12-09 15:42:27 UTC
Created attachment 212547 [details]
Kernel configuration

Added the kernel config.
Comment 9 Doron Fediuck 2009-12-09 15:43:43 UTC
Created attachment 212549 [details]
emerge info
Comment 10 Rob 2009-12-12 21:52:10 UTC
patch works perfect on x86_64 here.  Thanks.

I just added the one line in the 1.0.0.25 ebuild and saved the patch to files/patches/ dir and it worked great.
Comment 11 vvgloo 2009-12-22 05:11:27 UTC
Created attachment 213723 [details]
vmware-modules-1.0.0.25.patch-20631.out
Comment 12 vvgloo 2009-12-22 05:13:41 UTC
Comment on attachment 213723 [details]
vmware-modules-1.0.0.25.patch-20631.out

I have same error
but the patch can't help me

--------------------------------------------------------------------------------
* Failed Patch: vmware-modules-1.0.0.25.patch !
 *  ( /usr/portage/app-emulation/vmware-modules/files/vmware-modules-1.0.0.25.patch )
 * 
 * Include in your bugreport the contents of:
 * 
 *   /var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/temp/vmware-modules-1.0.0.25.patch-20631.out

 * ERROR: app-emulation/vmware-modules-1.0.0.25 failed:
 *   Failed Patch: vmware-modules-1.0.0.25.patch!
 * 
 * Call stack:
 *     ebuild.sh, line   61:  Called src_prepare
 *   environment, line 3876:  Called epatch '/usr/portage/app-emulation/vmware-modules/files/vmware-modules-1.0.0.25.patch'
 *   environment, line 1698:  Called die
 * The specific snippet of code:
 *                   die "Failed Patch: ${patchname}!";
 * 
 * If you need support, post the output of 'emerge --info =app-emulation/vmware-modules-1.0.0.25',
 * the complete build log and the output of 'emerge -pqv =app-emulation/vmware-modules-1.0.0.25'.
 * The complete build log is located at '/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/temp/environment'.
 * S: '/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/work'
--------------------------------------------------------------------------------


/var/tmp/portage/app-emulation/vmware-modules-1.0.0.25/temp/vmware-modules-1.0.0.25.patch-20631.out  :
Comment 13 vvgloo 2009-12-22 05:32:14 UTC
Sorry, my first time to use Bugs
I found the problem, my patch is not formatted correctly
I am now able to correctly compile vmware-modules with patch
very very sorry
Comment 14 devsk 2010-01-01 08:02:07 UTC
Why is this patch not in portage yet? Its been lying here for more than three weeks now.
Comment 15 Vadim Kuznetsov (RETIRED) gentoo-dev 2010-01-02 19:16:10 UTC
(In reply to comment #14)
> Why is this patch not in portage yet? Its been lying here for more than three
> weeks now.
> 

It's because I could not reliably reproduce this issue.
I think I can now. This settings will allow you to compile modules without this patch:
# CONFIG_PREEMPT_NONE is not set
# CONFIG_PREEMPT_VOLUNTARY is not set
CONFIG_PREEMPT=y

Setting Server or Desktop preemption model will trigger this issue.

I think this commit is the primary cause:
http://www.linuxhq.com/kernel/v2.6/32/include/linux/interrupt.h

Comment 16 Vadim Kuznetsov (RETIRED) gentoo-dev 2010-01-02 20:08:45 UTC
fixed in cvs.
Thanks.
Comment 17 Doron Fediuck 2010-01-03 07:37:28 UTC
(In reply to comment #16)
> fixed in cvs.
> Thanks.
> 

May I ask what was fixed in CVS ?
Should I change kernel settings or did you fix the commit which
causes this issue ?

Comment 18 Vadim Kuznetsov (RETIRED) gentoo-dev 2010-01-03 14:01:37 UTC
(In reply to comment #17)
> (In reply to comment #16)
> > fixed in cvs.
> > Thanks.
> > 
> 
> May I ask what was fixed in CVS ?

Rebuild modules and your proposed patch will be applied.

I did not bump ebuild, because you do not have to rebuild it if you already have it running. If you upgrade your kernel, you will rebuild modules regardless.

Thanks.
Comment 19 Doron Fediuck 2010-01-03 14:13:57 UTC
(In reply to comment #18)
> Rebuild modules and your proposed patch will be applied.
> 
> I did not bump ebuild, because you do not have to rebuild it if you already
> have it running. If you upgrade your kernel, you will rebuild modules
> regardless.
> 
> Thanks.
> 

Thank you !