When installing dev-lang/php with suhosin use flags without suhosin installed we have circullar reference because suhosin already depends on php. The only way to install it correctly: is install php without suhosin use flag, then install dev-php5/suhosin. After that add suhosin flag to php and reinstall php. Reproducible: Always
It doesn't do this for php-5.2.10... it seems that from 5.2.11 onwards we now have this in the ebuild: DEPEND="app-admin/php-toolkit imap? ( >=virtual/imap-c-client-2006k ) pcre? ( >=dev-libs/libpcre-7.8 ) xml? ( >=dev-libs/libxml2-2.7.2-r2 ) xmlrpc? ( >=dev-libs/libxml2-2.7.2-r2 virtual/libiconv ) suhosin? ( >=dev-php5/suhosin-0.9.29 )" Can this be changed to stop this dependency problem? Thanks, Rich
Created attachment 213232 [details, diff] Move the suhosin version dependency from DEPEND to PDEPEND to work around the ciruclar dependency
cla, is there a specific reason why you added suhosin as a build dependency? The eclass adds suhosin to PDEPEND for exactly this reason.. avoiding circular deps. I can fix it myself of course, but maybe there was a reason why you chose that way. See proposed patch.
(In reply to comment #3) > cla, is there a specific reason why you added suhosin as a build dependency? > The eclass adds suhosin to PDEPEND for exactly this reason.. avoiding circular > deps. > > I can fix it myself of course, but maybe there was a reason why you chose that > way. See proposed patch. > Go ahead and i did not - it was you. :) See http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/php/php-5.2.11.ebuild?r1=1.5&r2=1.6 What i did in -r1 was only gd max color patch + small condition to eclass to simply set patchset uri to something where non-maintainer can upload.
Committed for php-5.2.11 and php-5.2.11 (doesn't change installed files, so no version bump). Thanks for the report. (In reply to comment #4) > Go ahead and i did not - it was you. :) See > http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/php/php-5.2.11.ebuild?r1=1.5&r2=1.6 > > What i did in -r1 was only gd max color patch + small condition to eclass to > simply set patchset uri to something where non-maintainer can upload. Wah... sorry, I apologize for blaming you. I simply had no memories regarding this change and I just did a diff. Sorry...
(In reply to comment #5) > Committed for php-5.2.11 and php-5.2.11 (doesn't change installed files, so no > version bump). Thanks for the report. > > (In reply to comment #4) > > Go ahead and i did not - it was you. :) See > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/php/php-5.2.11.ebuild?r1=1.5&r2=1.6 > > > > What i did in -r1 was only gd max color patch + small condition to eclass to > > simply set patchset uri to something where non-maintainer can upload. > Wah... sorry, I apologize for blaming you. I simply had no memories regarding > this change and I just did a diff. Sorry... > No problem. But wait, you said the eclass does the thing and it does indeed: # Additional features # # They are in PDEPEND because we need PHP installed first! PDEPEND="doc? ( app-doc/php-docs ) filter? ( !dev-php5/pecl-filter ) java-external? ( dev-php5/php-java-bridge ) json? ( !dev-php5/pecl-json ) mcve? ( dev-php5/pecl-mcve ) pdo? ( !dev-php5/pecl-pdo ) suhosin? ( dev-php5/suhosin ) yaz? ( dev-php5/pecl-yaz )" So maybe revert that change and simply remove it from the DEPEND at all?
(In reply to comment #6) > So maybe revert that change and simply remove it from the DEPEND at all? Sorry, I don't get what you are after. The eclass has a generic PDEPEND on suhosin, php-5.2.11 has a version-specific PDEPEND on suhosin (previous versions crash). As this minimum version requirement does not apply for all ebuilds, I cannot move this requirement to the eclass, and as such, I cannot remove it from ebuild, or am I missing something?
