Bug 294709 – Enhance sys-apps/openrc-0.5.2-r2 to skip wiping tmpfs-mounted dirs

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Raffaello D. Di Napoli 2009-11-26 11:45:35 UTC]

Hi all,
I prepared a small patch to init.d/bootmisc(.in), adding a few lines to check if a directory it’s considering for wiping is really on tmpfs; if so, no operation occurs.
This assumes safely enough that bootmisc is run upon boot, so any tmpfs filesystem will be empty, no need to hunt for files to delete, and no useless “Wiping...” messages at the console.

Reproducible: Always

Steps to Reproduce:

[Comment 1 Raffaello D. Di Napoli 2009-11-26 11:48:10 UTC]

Created attachment 211243 [details, diff]
Adds function is_dir_tmpfs and calls to it in two spots

[Comment 2 Raffaello D. Di Napoli 2009-11-26 11:53:59 UTC]

Oh, I forgot to mention the patch is to be applied *after* openrc-0.5.2-dont-wipe-wtmp.patch, because it includes one line patched by the latter.

[Comment 3 Lars Wendler (Polynomial-C) (RETIRED) 2009-11-26 16:46:04 UTC]

Did you send these changes to upstream as well?

[Comment 4 Raffaello D. Di Napoli 2009-11-26 20:00:57 UTC]

(In reply to comment #3)
> Did you send these changes to upstream as well?

Done: 
http://roy.marples.name/projects/openrc/ticket/206

[Comment 5 SpanKY 2009-11-26 20:08:50 UTC]

the last statement would probably be clearer as:
		is_dir_tmpfs "$tmp" || cleanup_tmp_dir "$tmp"

[Comment 6 Raffaello D. Di Napoli 2009-11-29 17:53:31 UTC]

Upstream refused the patch, with very good arguments. Closing.