Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 294107 - media-libs/x264 : Newer x264 ebuilds needs git to enable proper 'configure' detect in other apps
Summary: media-libs/x264 : Newer x264 ebuilds needs git to enable proper 'configure' d...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-22 21:48 UTC by Io)
Modified: 2009-11-22 22:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Io) 2009-11-22 21:48:02 UTC
Hi,

I was searching to upgrade mplayer with x264 enabled, but looks like it doesn't x264 properly.

The media-libs/x264-0.0.20091021 ends in issuing a git command 

 * 	./version.sh: line 2: git: command not found

but installs properly

later on, while emerging whatever using x264 flag, the configure script says 

"##########################################

============ Checking for x264 ============

#include <inttypes.h>
#include <x264.h>
#if X264_BUILD < 78
#error We do not support old versions of x264. Get the latest from git.
#endif
int main(void) { x264_encoder_open((void*)0); return 0; }

i686-pc-linux-gnu-gcc -Wundef -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -O2 -march=native -fomit-frame-pointer -D__STDC_LIMIT_MACROS -fomit-frame-pointer -Ilibdvdread4 -I.  -D_REENTRANT  -I/usr/include/SDL  -D_REENTRANT -D_REENTRANT   -I/usr/include/freetype2     -Wl,-O1  -lncurses -lsmbclient -lpng -lz -ljpeg -lgif -lasound -ldl -lpthread -lfreetype -lz -lfontconfig  -lz -lbz2 -llzo2 -lvorbis -logg -ltheora -logg   -ldts -ldv -lxvidcore -lm   -lXext -lX11 -lpthread -lXxf86vm -lGL -ldl -lSDL -lpthread -lpulse    -o /var/tmp/portage/media-video/mplayer-1.0_rc4_p20091026-r1/temp/mplayer-conf-4400-2590 /var/tmp/portage/media-video/mplayer-1.0_rc4_p20091026-r1/temp/mplayer-conf-29803-2590.c -lx264 -lpthread
/var/tmp/portage/media-video/mplayer-1.0_rc4_p20091026-r1/temp/mplayer-conf-29803-2590.c:4:2: error: #error We do not support old versions of x264. Get the latest from git."

So IMHO a git/curl use flag should be added ? Or simply get the version by http/wget ?




Reproducible: Always

Steps to Reproduce:
1.Emerge media-libs/x264
2.Emerge whatever using x264 flag 
3. Configure says "Checking for x264 ... no"



Expected Results:  
"Checking for x264 ... yes"
Comment 1 Alexis Ballier gentoo-dev 2009-11-22 22:02:32 UTC
(In reply to comment #0)
> The media-libs/x264-0.0.20091021 ends in issuing a git command 
> 
>  *      ./version.sh: line 2: git: command not found

this only changes the internal version... instead of getting:
#define X264_POINTVER "0.78.1301 bcba15d"
you get:
#define X264_POINTVER "0.78.x"

which is never exported and used only by x264.c...


what you should check is which x264.h files is included instead. 20091021 *always* installs a x264.h containing "#define X264_BUILD 78"