Was accidentally looking at the code and noticed following issues: * Lines 49, 51, 57, 61, 64, 68, 69, 70, 71, 72, 73, 74, 78 aren't being checked for errors. * Packages are not necessarily being emerged on a computer on which they will run. Thus the check on lines 38-40 doesn't always work. The best way to do this, IMO, would be an ewarn stating the problem. It may be that other ebuilds in the directory are also affected.
I have no clue what you are talking about. PLease be more clear where the problem is.
Created attachment 210438 [details, diff] Proposed changes I was suggesting that these changes be applied to the ebuild. Thanks.
Okay now I understand.
Assigning to maintainer.
Thanks for the report! Updated changes committed, a few remarks: * You can check if the package installs on the current system with the ${ROOT} variable (and then can die in pkg_preinst if $ROOT == "/"). For the others adding an ewarn is good indeed * wget check is not needed, as the fetched source is immediately unpacked (and will therefore fail). That is inspired from default src fetching * do* (dobin, dosym, ...) in src_install: in fixed releases, it's up to the maintainer to check that the files he wants to install exist ;) So no need to add them. For -9999, this is not a bad idea, for critical parts (as other parts can disappear without problem, like locale/ recently). Also, when you have more than one die call in your ebuild, it's better to set specific error messages for everyone of them (helps debugging!) Thanks again, changes committed in the 3 current in-tree ebuilsd
Thanks for clarification. I was meaning that the do* helpers are more likely to fail with "Not enough space" or "I/O error", but otherwise you are fully correct.
