Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 29309 - lcms-1.11 ebuild contains redundant code
Summary: lcms-1.11 ebuild contains redundant code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal
Assignee: Heinrich Wendel (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-21 21:39 UTC by Brandy Westcott (RETIRED)
Modified: 2003-09-22 07:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brandy Westcott (RETIRED) gentoo-dev 2003-09-21 21:39:20 UTC
The lcms-1.11 ebuild contains a redundant block of code that seemsto be 
a throwback to the old lcms-1.09 ebuild where there was no configure 
script and the tiff and jpeg utils had to be explicitely built: 
 
 
	src_install() { 
		..... 
		( use tiff && use jpeg ) && ( \ 
		make \ 
			DESTDIR=${D} \ 
			utils || die 
		) 
		..... 
	} 
 
 
In fact the configure-genreated Makefile in lcms-1.11 doesn't contain 
the target utils and when emerging the following error is encountered: 
 
 
	make: *** No rule to make target `utils'.  Stop. 
 
	!!! ERROR: media-libs/lcms-1.11 failed. 
	!!! Function src_install, Line 38, Exitcode 2 
	!!! (no error message) 
 
 
(Since the die statement is nested within parentheses the compile 
doesn't stop; apart from this annoying error message, nothing untoward 
happens.)  
 
It also might be worthwhile making tiff and jpeg optional dependencies 
of lcms since they don't need to be installed if we don't want the tiff 
and jpeg utils.
Comment 1 Heinrich Wendel (RETIRED) gentoo-dev 2003-09-22 07:11:51 UTC
thx, fixed :)