Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 292615 - dev-util/stgit-0.15 version bump
Summary: dev-util/stgit-0.15 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: http://www.procode.org/stgit/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-10 00:25 UTC by René 'Necoro' Neumann
Modified: 2009-11-11 16:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
stgit-0.15.ebuild (stgit-0.15.ebuild,1.41 KB, text/plain)
2009-11-10 00:25 UTC, René 'Necoro' Neumann
Details
stgit-0.15.ebuild (stgit-0.15.ebuild,1.39 KB, text/plain)
2009-11-10 00:30 UTC, René 'Necoro' Neumann
Details
fixed ebuild (stgit-0.15.ebuild,1.38 KB, text/plain)
2009-11-10 17:44 UTC, Markos Chandras (RETIRED)
Details
ebuild with doc flag (stgit-0.15.ebuild,1.63 KB, text/plain)
2009-11-11 15:51 UTC, René 'Necoro' Neumann
Details
ebuild with doc flag (stgit-0.15.ebuild,1.69 KB, text/plain)
2009-11-11 16:01 UTC, René 'Necoro' Neumann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description René 'Necoro' Neumann 2009-11-10 00:25:23 UTC
After quite some time, there is a new stgit release. Find a changelog on the linked homepage.

I have managed to write an ebuild for it. This is more or less a complete rewrite, so I will attach it directly and not a diff.

The only thing broken atm is one test which fails though it should not :). I guess, this is worth a bug report.

Oh -- and when you can't find a maintainer and someone wants to proxy me, I could have an eye on it. (I do not use it that often, but I use it from time to time.)
Comment 1 René 'Necoro' Neumann 2009-11-10 00:25:57 UTC
Created attachment 209783 [details]
stgit-0.15.ebuild
Comment 2 René 'Necoro' Neumann 2009-11-10 00:30:48 UTC
Created attachment 209784 [details]
stgit-0.15.ebuild

I should've run repoman before ^^
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2009-11-10 17:44:31 UTC
Created attachment 209847 [details]
fixed ebuild

I did some modifications to your ebuild. Could you please test the new ebuild. If it works ok for you, I will commit it on portage tree. Thanks
Comment 4 René 'Necoro' Neumann 2009-11-10 20:42:08 UTC
Ehm ... sorry ... but ... you could have run your ebuild on your own first. Not only would you have noted a typo of yours, but also noted, that I avoided all the 'emake install-*' and plain 'emake' for a purpose. For the latter I even put in a comment ...

The other things: Adding a doc useflag sounds like a good thing on the first sight, as compiling the docs is what takes the most time. On the other hand: I think installing the man-pages by default sounds quite reasonable. And having the html-stuff additional to man ... well I'm not sure ... one could do this, but for me it looks like wasting disk space for no reason.
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2009-11-11 09:33:20 UTC
(In reply to comment #4)
> Ehm ... sorry ... but ... you could have run your ebuild on your own first. 
I did
>Not
> only would you have noted a typo of yours,
what typo?
 but also noted, that I avoided all
> the 'emake install-*' and plain 'emake' for a purpose. For the latter I even
> put in a comment ...
I dont understand the comment. Have you read the actual INSTALL file? emake and emake docs seems more reasonable to me and this is what upstream suggests as well
> 
> The other things: Adding a doc useflag sounds like a good thing on the first
> sight, as compiling the docs is what takes the most time. On the other hand: I
> think installing the man-pages by default sounds quite reasonable.
Indeed
 And having
> the html-stuff additional to man ... well I'm not sure ... 
Personally I do prefer html pages when available.
one could do this,
> but for me it looks like wasting disk space for no reason.
> 
And this is why html pages is optional ( doc use flag )
Comment 6 René 'Necoro' Neumann 2009-11-11 15:49:27 UTC
One after the other:

1) I have of course read the INSTALL file. But additionally I have also looked into the Makefiles and noticed, that it does things different then we expect:
  - normally it assumes to install into $HOME
  - even more, the path to install HTML files to is not what we want
  
  Thus I have not used the install* procedures, but used what portage provides. (One could of course patch the makefiles and then use make. But I thought this to be way more complex.)

2) The python guys at gentoo have invested quite some thoughts in handling different python issues in the distutils-eclass. Thus I want to use the methods provided there, instead of using the makefile. (Else the latter might prove as problem later on...)

3) Your typo was 'isntall-html'. Because of this and 1) (which should result in a build failure and no documentation being installed), I thought, that you did not test it.

4) The doc useflag: I would vote for one of two possible ways: Have a 'doc' flag and install man and html if and only if it is set. Or do not have the flag and all and install both things unconditionally.
Differentiating between man and html does not make sense imho. (I hereby revert my previous statement in that matter :)).

For the IUSE=doc way, I'll attach an ebuild.
Comment 7 René 'Necoro' Neumann 2009-11-11 15:51:22 UTC
Created attachment 209920 [details]
ebuild with doc flag

Here it is the ebuild with the doc flag. I also clarified some comments in it :)
Comment 8 René 'Necoro' Neumann 2009-11-11 16:01:26 UTC
Created attachment 209923 [details]
ebuild with doc flag

Fixed the warning message.
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2009-11-11 16:08:09 UTC
Committed . Thanks for your hard work :)

+*stgit-0.15 (11 Nov 2009)
+
+  11 Nov 2009; Markos Chandras <hwoarang@gentoo.org> +stgit-0.15.ebuild:
+  Version bump. Fixes bug 292615. Thanks to René 'Necoro' Neumann
+  <gentoo@necoro.eu> for the ebuilds and recommendations
+