Bug 291976 – sys-apps/dbus-1.3.0-r1 fails to build on any platform without HAVE_UNIX_FD_PASSING

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Stuart Shelton 2009-11-05 12:57:17 UTC]

The DBusMessage structure includes unix_fds, n_unix_fds, n_unix_fds_allocated, and unix_fd_counter_delta iff HAVE_UNIX_FD_PASSING is set.

However, the dbus_message_contians_unix_fds() function from dbus-message.c unconditionally accesses one of these elements of the structure, leading to a compilation failure.

The obvious answer seems to be to return FALSE in response to dbus_message_contains_unix_fds without HAVE_UNIX_FD_PASSING, as that result seems to be implicit.

[Comment 1 Stuart Shelton 2009-11-05 12:58:45 UTC]

Created attachment 209324 [details, diff]
Patch to allow dbus_message.c to build when HAVE_UNIX_FD_PASSING is not set

[Comment 2 Heiko 2009-11-08 10:01:53 UTC]

Just to note, this has been fixed in upstream's vcs:
  the bug: https://bugs.freedesktop.org/show_bug.cgi?id=22888
and
  the commit: http://cgit.freedesktop.org/dbus/dbus/commit/?id=c1a31b6b30dc683f219ffb8c655138b07a12a187

Maybe that patch should be used/quoted.

[Comment 3 Fabian Groffen 2009-11-11 14:01:13 UTC]

upstream patch applied, thanks