Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 291702 - media-sound/mpc-0.18 : bash-completion doesn't work
Summary: media-sound/mpc-0.18 : bash-completion doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Christoph Mende (RETIRED)
URL: http://musicpd.org/mantis/view.php?id...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 13:32 UTC by Man Shankar
Modified: 2009-12-11 05:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mpc-0.18-bash-completion.patch (mpc-0.18-bash-completion.patch,349 bytes, patch)
2009-11-25 11:50 UTC, Christoph Mende (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Man Shankar 2009-11-03 13:32:47 UTC
After upgrading to media-sound/mpc-0.18, tab completion no longer works. Downgrading to media-sound/mpc-0.16, restores expected behaviour.

Reproducible: Always

Steps to Reproduce:
1.emerge -avu media-sound/mpc
2.eselect bashcomp enable mpc


Actual Results:  
These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild     U ] media-sound/mpc-0.18 [0.16] USE="bash-completion iconv" 0 kB

Total: 1 package (1 upgrade), Size of downloads: 0 kB

Would you like to merge these packages? [Yes/No]

Packages installs fine, but bash-completion only completes the "status" command.

Expected Results:  
mpc <tab> should show all completions, instead of just status

$ emerge --info

Portage 2.2_rc48 (default/linux/amd64/10.0/desktop, gcc-4.4.2, glibc-2.10.1-r0, 2.6.31-gentoo-r4 x86_64)
=================================================================
System uname: Linux-2.6.31-gentoo-r4-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_3800+-with-gentoo-2.0.1
Timestamp of tree: Tue, 03 Nov 2009 09:45:01 +0000
app-shells/bash:     4.0_p35
dev-java/java-config: 2.1.9-r1
dev-lang/python:     2.6.4, 3.1.1-r1
dev-util/cmake:      2.6.4-r3
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.5.2-r1
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.63-r1
sys-devel/automake:  1.9.6-r2, 1.10.2, 1.11
sys-devel/binutils:  2.20
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=athlon64 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y"
FEATURES="assume-digests distlocks fixpackages news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://gentoo.gg3.net/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/home/manshankar/OSWork/portage"
SYNC="rsync://rsync.asia.gentoo.org/gentoo-portage"
USE="3dnow X a52 aac aalib acl acpi alsa amd64 bash-completion berkdb bluetooth branding bzip2 cairo cdr cli consolekit cracklib crypt dbus directfb dri dts dvd dvdr eds emboss encode evo exif fam fbcon ffmpeg firefox flac fontforge fortran gdbm gif gnutls gpm gstreamer gtk hal iconv idn ipv6 java6 jpeg libnotify mad mikmod mmx modules mp3 mp4 mpeg mudflap multilib ncurses nls nptl nptlonly nsplugin offensive ogg opengl openmp oss pam pcre pdf perl png ppds pppd python qt3support qt4 quicktime readline reflection sasl sdl session spell spl sse sse2 ssl startup-notification svg sysfs tcpd threads thunar tiff truetype unicode usb vim-syntax vorbis x264 xcomposite xml xorg xulrunner xv xvid zlib zsh-completion" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="nvidia nv" 
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Man Shankar 2009-11-03 16:25:58 UTC
Probably the upstream commit aa911685ce5a25fa158aaf4f79b89bd1e3bc2676, totally broke bash-completion.

http://git.musicpd.org/cgit/master/mpc.git/commit/?id=aa911685ce5a25fa158aaf4f79b89bd1e3bc2676
Comment 2 Christoph Mende (RETIRED) gentoo-dev 2009-11-15 19:02:39 UTC
Which mpd version are you using?
Comment 3 Man Shankar 2009-11-16 10:24:19 UTC
(In reply to comment #2)
> Which mpd version are you using?
> 
The latest available on ~amd64.
media-sound/mpd-0.15.5.

It is strange, because the above commit only adds a print_usage() function. But, reverting it works for me.
Comment 4 Christoph Mende (RETIRED) gentoo-dev 2009-11-22 10:26:25 UTC
It seems like upstream is not interested in fixing the bash completion and I unfortunately have no idea how to fix this (apart from reverting the commit which is not the right way).
I'll try to look into that whole bash completion stuff as soon as I find the time for it, but will also track other distros for patches, if you find or write one, feel free to send it to me and to the upstream bug.
Comment 5 Man Shankar 2009-11-23 13:15:59 UTC
(In reply to comment #4)
> It seems like upstream is not interested in fixing the bash completion and I
> unfortunately have no idea how to fix this (apart from reverting the commit
> which is not the right way).
> I'll try to look into that whole bash completion stuff as soon as I find the
> time for it, but will also track other distros for patches, if you find or
> write one, feel free to send it to me and to the upstream bug.

I agree with you, reverting the commit is no fix at all. Meanwhile, i have started using ZSh and its completion works well for me. sorry, i have no idea about completion myself. In the mean time if you like, u can mark the bug as Upstream.
Comment 6 Christoph Mende (RETIRED) gentoo-dev 2009-11-23 13:49:21 UTC
Nah, upstream won't fix it, I'll leave this open so I won't forget it
Comment 7 Christoph Mende (RETIRED) gentoo-dev 2009-11-25 11:50:51 UTC
Created attachment 211147 [details, diff]
mpc-0.18-bash-completion.patch

can you please test attached patch for me?
Comment 8 Man Shankar 2009-12-06 15:19:24 UTC
(In reply to comment #7)
> Created an attachment (id=211147) [details]
> mpc-0.18-bash-completion.patch
> 
> can you please test attached patch for me?
> 

Sorry, for being soo late on this. Unfortunately, the patch doesn't work for me. Same behavior persists. Does it work for you? 

Regards.
Comment 9 Man Shankar 2009-12-06 17:56:19 UTC
(In reply to comment #7)
> Created an attachment (id=211147) [details]
> mpc-0.18-bash-completion.patch
> 
> can you please test attached patch for me?
> 

Replacing \s with a space in the patch, seems to work. Also, the suggested git version in your bug report to upstream, works very well.

Thanks & Regards!
Comment 10 Christoph Mende (RETIRED) gentoo-dev 2009-12-10 13:58:29 UTC
Well then, 0.19 is in the tree
Comment 11 Man Shankar 2009-12-11 05:31:53 UTC
(In reply to comment #10)
> Well then, 0.19 is in the tree
> 

Thank You.