Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 29157 - wmcp does not compile with GCC 3.3, but this is EASILY solvable
Summary: wmcp does not compile with GCC 3.3, but this is EASILY solvable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Seemant Kulleen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-19 17:15 UTC by Christopher Culver
Modified: 2003-09-24 15:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Culver 2003-09-19 17:15:13 UTC
x11-plugins/wmcp did not compile for me with GCC 3.3, which I traced to the
massive string in wmcp.c (around line 812) for the help output. GCC 3.3 does not
like having a string split over so many lines. Replacing the returns with "\n"
will solve the problem. Here's a patch that works (with it I installed wmcp fine):

--- wmcp.c	1999-05-27 08:38:49.000000000 +0200
+++ wmcp.c	2003-09-19 10:47:19.000000000 +0200
@@ -806,39 +806,7 @@
 void show_usage()
 {
 
-fprintf(stderr,"
-
-%s
-This software is GPL -- do as you wish with it.
-
-Origional Author:
-   Ben Cohen <buddog@aztec.asu.edu>
-
-Contributors:
-   Thomas Nemeth <tnemeth@multimania.com>
-   Craig Maloney <craig@ic.net>
-   Gert Beumer <Gert@scintilla.utwente.nl>
-
-
-
-usage: wmcp [-g geometry] [-d dpy] [-n workspaces] [-a alt key] [-v]
-            [-c] [-w i/n/w] [-s y/n] [-x #] [-y #] [-h]
-
-
--g    geometry:    ie: 64x64+10+10
--d    dpy:         Display. ie: 127.0.0.1:0.0
--n    workspaces:  How many buttons to start with.
--a    alt key:     integer 1-4 defining ModXMask (default 1 Mod1Mask).
--w    i/n/w:       Window State: Iconic, Normal, Withdrawn (default Withdrawn)
--s    y/n:         Shaped window: yes or no (default y)
--c                 Sends CTRL + ALT + Key (default only sends ALT + key)
--v                 Verbose. 0=off, 1=on (default 0)
--x                 Number of buttons on the x-direction (1,2,3, or 4)
--y                 Number of buttons in the y-direction (1,2,3, or 4)
--h                 Help. This screen.
-
-
-",VERSION);
+fprintf(stderr,"\n%s\nThis software is GPL -- do as you wish with
it.\n\nOriginal Author:\n   Ben Cohen <buddog@aztec.asu.edu>\n\nContributors:\n
  Thomas Nemeth <tnemeth@multimania.com>\n   Craig Maloney <craig@ic.net>\n  
Gert Beumer <Gert@scintilla.utwente.nl>\n\n\n\nusage: wmcp [-g geometry] [-d
dpy] [-n workspaces] [-a alt key] [-v]\n            [-c] [-w i/n/w] [-s y/n] [-x
#] [-y #] [-h]\n\n\n-g    geometry:    ie: 64x64+10+10\n-d    dpy:        
Display. ie: 127.0.0.1:0.0\n-n    workspaces:  How many buttons to start
with.\n-a    alt key:     integer 1-4 defining ModXMask (default 1
Mod1Mask).\n-w    i/n/w:       Window State: Iconic, Normal, Withdrawn (default
Withdrawn)\n-s    y/n:         Shaped window: yes or no (default y)\n-c        
        Sends CTRL + ALT + Key (default only sends ALT + key)\n-v              
  Verbose. 0=off, 1=on (default 0)\n-x                 Number of buttons on the
x-direction (1,2,3, or 4)\n-y                 Number of buttons in the
y-direction (1,2,3, or 4)\n-h                 Help. This screen.\n\n\n",VERSION);
 
 exit(-1);
 }


Reproducible: Always
Steps to Reproduce:
1. Try to compile x11-plugins/wmcp with GCC 3.3
2.
3.

Actual Results:  
root@portebla root # emerge wmcp
Calculating dependencies ...done!
>>> emerge (1 of 1) x11-plugins/wmcp-1.2.8 to /
>>> md5 src_uri ;-) wmcp-1.2.8.tar.gz
>>> Unpacking source...
>>> Unpacking wmcp-1.2.8.tar.gz to /var/tmp/portage/wmcp-1.2.8/work
patching file Makefile
>>> Source unpacked.
if [ -e buttons.xpm ];             then rm buttons.xpm; fi
if [ -e pushed_buttons.xpm ];      then rm pushed_buttons.xpm; fi
if [ -e backdrop.xpm ];            then rm backdrop.xpm; fi
ln -s buttons-scalpel.xpm          buttons.xpm
ln -s pushed_buttons-scalpel.xpm   pushed_buttons.xpm
ln -s backdrop-scalpel.xpm         backdrop.xpm
make clean
make[1]: Entering directory `/var/tmp/portage/wmcp-1.2.8/work/wmcp-1.2.8'
for i in wmcp.o; do if [ -e $i ] ; then rm $i; fi; done
if [ -e wmcp ] ; then rm wmcp; fi
make[1]: Leaving directory `/var/tmp/portage/wmcp-1.2.8/work/wmcp-1.2.8'
make wmcp
make[1]: Entering directory `/var/tmp/portage/wmcp-1.2.8/work/wmcp-1.2.8'
gcc -g -c -Wall -I/usr/X11R6/include/X11  wmcp.c -o wmcp.o
In file included from wmcp.c:31:
backdrop.xpm:75:1: warning: no newline at end of file
wmcp.c: In function `main':
wmcp.c:214: warning: implicit declaration of function `exit'
wmcp.c:809:16: missing terminating " character
wmcp.c: In function `show_usage':
wmcp.c:812: error: `s' undeclared (first use in this function)
wmcp.c:812: error: (Each undeclared identifier is reported only once
wmcp.c:812: error: for each function it appears in.)
wmcp.c:812: error: syntax error before "This"
wmcp.c:815: error: syntax error at '@' token
wmcp.c:818: error: syntax error at '@' token
wmcp.c:819: error: syntax error at '@' token
wmcp.c:820: error: syntax error at '@' token
wmcp.c:825: error: syntax error at '#' token
wmcp.c:825: error: syntax error at '#' token
wmcp.c:828:24: invalid suffix "x64" on integer constant
wmcp.c:829:33: too many decimal points in number
wmcp.c:841:1: missing terminating " character
make[1]: *** [wmcp.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/wmcp-1.2.8/work/wmcp-1.2.8'
make: *** [scalpel] Error 2

!!! ERROR: x11-plugins/wmcp-1.2.8 failed.
!!! Function src_compile, Line 28, Exitcode 2
!!! make failed

Expected Results:  
Compile cleanly
Comment 1 Seemant Kulleen (RETIRED) gentoo-dev 2003-09-19 22:38:04 UTC
christopher, can I have you either attach the patch to this bug or in an email to me, please?
Comment 2 Seemant Kulleen (RETIRED) gentoo-dev 2003-09-24 15:27:04 UTC
added in portage.