Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 29156 - razor needs a taint patch
Summary: razor needs a taint patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 29404
  Show dependency tree
 
Reported: 2003-09-19 16:08 UTC by Wayne Davison
Modified: 2004-01-20 16:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
The razor patch from Mail-SpamAssassin (razor-taint.patch,1.08 KB, patch)
2003-09-19 16:16 UTC, Wayne Davison
Details | Diff
Patch for both the razor-2.36.ebuild and the razor-2.20.ebuild. (razor-ebuild.patch,787 bytes, patch)
2003-09-19 16:26 UTC, Wayne Davison
Details | Diff
The untaint patch from Mail-SpamAssassin 2.60 (final) (razor-taint.patch,2.08 KB, patch)
2003-09-24 09:50 UTC, Wayne Davison
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Davison 2003-09-19 16:08:04 UTC
The latest SpamAssassin release comes with a patch for razor that makes the
library work when perl's taint mode (-T) is turned on.  The patch is very simple
(it just untaints a couple variables), but it is required to avoid a fatal error
when an application calls the library with taint mode enabled.

I'll attach the razor patch and an ebuild patch to use it.
Comment 1 Wayne Davison 2003-09-19 16:16:05 UTC
Created attachment 18004 [details, diff]
The razor patch from Mail-SpamAssassin

Tweaked by me to remove the prefixed comments and to add the full path of the
files we're changing.
Comment 2 Wayne Davison 2003-09-19 16:26:16 UTC
Created attachment 18005 [details, diff]
Patch for both the razor-2.36.ebuild and the razor-2.20.ebuild.

This patch not only adds a src_unpack() section to apply the razor-taint.patch
(found in attachment 18004 [details, diff]), but it also makes the minor change of setting "P"
instead of "S" (since we need to refer to the modified P value in several
places and S depends on P, so it's easier this way).

The fix should be applied to both 2.36 and 2.20:

cd /usr/portage/net-mail/razor
patch -p0 <razor-ebuild.patch
patch -p0 razor-2.20.ebuild <razor-ebuild.patch
Comment 3 Malte S. Stretz 2003-09-24 04:30:10 UTC
The attached patch against Razor is an older one. There's now a revisited one in the 
SpamAssassin 2.60-final tarball. 
Comment 4 Wayne Davison 2003-09-24 09:50:45 UTC
Created attachment 18269 [details, diff]
The untaint patch from Mail-SpamAssassin 2.60 (final)

Updated the patch to the version from Mail-SpamAssassin's final 2.60 release.
Also updated the line numbers to match the 2.36 release's files.
Comment 5 Wayne Davison 2003-09-24 09:57:05 UTC
One extra note: if the untaint patch is used with the 2.20 release, it will generate some *.orig files (since the line numbers aren't quite the same) and they will be installed into the perl library dir.  Thus, the 2.20 ebuild would need the patch command to be tweaked to add the --no-backup-if-mismatch option to avoid this.
Comment 6 Robert Coie (RETIRED) gentoo-dev 2003-09-26 16:32:30 UTC
2.36 is patched in -r1.
Comment 7 SpanKY gentoo-dev 2004-01-20 16:19:25 UTC
guess rac forgot to close out this bug ;)