Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 291530 - games-strategy/glest-3.2.2 ebuild passes invalid options to jam
Summary: games-strategy/glest-3.2.2 ebuild passes invalid options to jam
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-02 06:46 UTC by Ken Rushia
Modified: 2009-11-02 06:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Rushia 2009-11-02 06:46:53 UTC
Ebuild passes MAKEOPTS to jam, which can contain unsupported switches (jam is not make). The ebuild has a sed hack that assumes the only thing that would be in MAKEOPTS is -j.

src_compile() {
        local jamopts=$(echo "${MAKEOPTS}" | sed -ne "/-j/ { s/.*\(-j[0-9]\+\).*/\1/; p }")
        jam -dx -q ${jamopts} || die "jam failed"
}


My suggestion is to remove the MAKEOPTS reference altogether.

Reproducible: Always

Steps to Reproduce:
1. Put something besides -j in MAKEOPTS (example: MAKEOPTS="-j 1 -l 0.7").
2. emerge glest

Actual Results:  
>>> Compiling source in /var/tmp/portage/games-strategy/glest-3.2.2/work/glest-source-3.2.2 ...
Invalid option: -l
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2009-11-02 06:57:13 UTC
fixed.