Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 291360 - samba-client-3.4.3 doesn't compile: cifs.upcall.c:97: error: incompatible type for argument 1 of ‘k5_data_equal’
Summary: samba-client-3.4.3 doesn't compile: cifs.upcall.c:97: error: incompatible typ...
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
: 291435 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-31 19:41 UTC by Harald van Dijk (RETIRED)
Modified: 2010-01-07 20:12 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
use heim_general_string instead of krb5_data struct (samba-3.4.3-cifs_upcall_c.patch,1.59 KB, patch)
2009-11-03 10:44 UTC, Marcel Greter
Details | Diff
Ebuild for samba-client-3.4.3 with cifs_upcall.c patch (samba-client-3.4.3.ebuild,6.79 KB, patch)
2009-11-09 11:14 UTC, Corin Goodier
Details | Diff
samba-3.4.3-cifs_upcall_c.patch file modified for ebuild/src tree (samba-3.4.3-cifs_upcall_c.patch,1.59 KB, patch)
2009-11-09 11:15 UTC, Corin Goodier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harald van Dijk (RETIRED) gentoo-dev 2009-10-31 19:41:21 UTC
Compiling client/cifs.upcall.c
client/cifs.upcall.c: In function ‘get_tgt_time’:
client/cifs.upcall.c:97: error: incompatible type for argument 1 of ‘k5_data_equal’
client/cifs.upcall.c:48: note: expected ‘krb5_data’ but argument is of type ‘Realm’
client/cifs.upcall.c:97: error: incompatible type for argument 2 of ‘k5_data_equal’
client/cifs.upcall.c:48: note: expected ‘krb5_data’ but argument is of type ‘Realm’
client/cifs.upcall.c:98: error: ‘struct Principal’ has no member named ‘data’
client/cifs.upcall.c:99: error: ‘struct Principal’ has no member named ‘data’
client/cifs.upcall.c:99: error: incompatible type for argument 2 of ‘k5_data_equal’
client/cifs.upcall.c:48: note: expected ‘krb5_data’ but argument is of type ‘Realm’
client/cifs.upcall.c:109: error: ‘KRB5_TC_OPENCLOSE’ undeclared (first use in this function)
client/cifs.upcall.c:109: error: (Each undeclared identifier is reported only once
client/cifs.upcall.c:109: error: for each function it appears in.)
The following command failed:
i686-pc-linux-gnu-gcc -march=athlon64 -O2 -I. -I/var/tmp/portage/net-fs/samba-client-3.4.3/work/samba-3.4.3/source3 -Iinclude -I./include  -I. -I. -I./../lib/replace   -I./../lib/tevent -I./../lib/tdb/include -I./libaddns -I./librpc -I./.. -DHAVE_CONFIG_H  -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Iinclude -I./include -I. -I. -I./../lib/replace -I./../lib/tevent -I./../lib/tdb/include -I./libaddns -I./librpc -I./.. -I./../lib/popt -DLDAP_DEPRECATED  -I/var/tmp/portage/net-fs/samba-client-3.4.3/work/samba-3.4.3/source3/lib -I.. -I../source4 -D_SAMBA_BUILD_=3 -I. -I/var/tmp/portage/net-fs/samba-client-3.4.3/work/samba-3.4.3/source3 -Iinclude -I./include  -I. -I. -I./../lib/replace   -I./../lib/tevent -I./../lib/tdb/include -I./libaddns -I./librpc -I./.. -DHAVE_CONFIG_H  -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Iinclude -I./include -I. -I. -I./../lib/replace -I./../lib/tevent -I./../lib/tdb/include -I./libaddns -I./librpc -I./.. -I./../lib/popt -DLDAP_DEPRECATED  -I/var/tmp/portage/net-fs/samba-client-3.4.3/work/samba-3.4.3/source3/lib -I.. -I../source4 -D_SAMBA_BUILD_=3 -fPIC -c client/cifs.upcall.c -o client/cifs.upcall.o
make: *** [client/cifs.upcall.o] Error 1
 * ERROR: net-fs/samba-client-3.4.3 failed:
 *   emake cifs.upcall failed
 * 
 * Call stack:
 *     ebuild.sh, line  49:  Called src_compile
 *   environment, line 3864:  Called die
 * The specific snippet of code:
 *           emake bin/cifs.upcall || die "emake cifs.upcall failed";

emerge -pv samba-client:
[ebuild   R   ] net-fs/samba-client-3.4.3  USE="ads* cups ldap* samba4* -aio -avahi -caps -cluster -debug -minimal -syslog -winbind -zeroconf" 0 kB

emerge --info:
Portage 2.2_rc47 (default/linux/x86/2008.0/desktop/multilib, gcc-4.4.2, glibc-2.10.1-r0, 2.6.31-gentoo-r4 i686)
=================================================================
System uname: Linux-2.6.31-gentoo-r4-i686-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_4200+-with-gentoo-2.0.1
Timestamp of tree: Sat, 31 Oct 2009 16:25:01 +0000
app-shells/bash:     4.0_p35
dev-java/java-config: 2.1.9-r1
dev-lang/python:     2.6.4
dev-util/cmake:      2.6.4-r3
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.5.2-r1
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.63-r1
sys-devel/automake:  1.9.6-r2, 1.10.2, 1.11
sys-devel/binutils:  2.20
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=athlon64 -O2"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--noconfmem --verbose --with-bdeps=y"
FEATURES="assume-digests autopatch fixpackages news notitles nouserflags preserve-libs protect-owned sandbox sfperms strict unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://mirror.leaseweb.com/gentoo/"
LANG="en_GB.UTF-8"
LDFLAGS="-Xlinker -O1 -Xlinker --as-needed"
LINGUAS="*"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/etc/portage/layman/java-overlay /etc/portage/layman/sunrise /etc/portage/crossdev /etc/portage/overlay /var/cvs/gentoo-x86"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac accessibility acl acpi ads alsa apache2 aspell berkdb bindist bzip2 cairo cdda cdparanoia cdr cjk cli cracklib crypt cups cvs dbus demo dri dts dvd dvdr eds emacs emboss encode evo fam ffmpeg firefox flac gcc64 gdbm gif git gnome-keyring gstreamer gtk iconv inotify ipv6 isdnlog ithreads java5 java6 javascript jit jpeg kvm latex lcms ldap mad mbox mikmod mmx mmxext mng mp3 mp4 mpeg mudflap multilib ncurses nls nocxx normalize nptl nptlonly nsplugin ntfs ogg opengl openmp oss pam pcre pdf pdo perl pic png postgres ppds pppd preview-latex python qt3support quicktime radio rdp readline reflection samba samba4 sdl session smbclient spell spl sql sqlite sse sse2 ssl startup-notification subversion svg swat symlink sysfs tcl tcpd theora threads thunar tidy tiff timidity tk tokenizer toolkit-scroll-bars truetype udev unicode usb v4l v4l2 vhosts videos vim-syntax vorbis webkit x264 x86 xattr xcomposite xml xorg xscreensaver xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="*" USERLAND="GNU" VIDEO_CARDS="nv vesa" 
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Bernie Hackett 2009-10-31 23:11:24 UTC
I have the same problem. It builds with USE='-ads -samba4'.
Comment 2 Maxim Kraev 2009-11-01 15:27:10 UTC
Same problem with samba4 ads
emerge --info
Portage 2.1.7.3 (default/linux/amd64/10.0/desktop, gcc-4.3.4, glibc-2.10.1-r0, 2.6.31-gentoo-r3-v1 x86_64)                 
=================================================================                                                          
System uname: Linux-2.6.31-gentoo-r3-v1-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_4400+-with-gentoo-2.0.1            
Timestamp of tree: Sun, 01 Nov 2009 11:00:01 +0000                                                                         
distcc 3.1 x86_64-pc-linux-gnu [disabled]                                                                                  
ccache version 2.4 [enabled]                                                                                               
app-shells/bash:     4.0_p35                                                                                               
dev-java/java-config: 2.1.9-r1                                                                                             
dev-lang/python:     2.6.3, 3.1.1-r1                                                                                       
dev-util/ccache:     2.4-r8                                                                                                
dev-util/cmake:      2.6.4-r3                                                                                              
sys-apps/baselayout: 2.0.1                                                                                                 
sys-apps/openrc:     0.5.2-r1                                                                                              
sys-apps/sandbox:    2.2                                                                                                   
sys-devel/autoconf:  2.13, 2.63-r1                                                                                         
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2, 1.11                                                            
sys-devel/binutils:  2.20                                                                                                  
sys-devel/gcc-config: 1.4.1                                                                                                
sys-devel/libtool:   2.2.6a                                                                                                
virtual/os-headers:  2.6.30-r1                                                                                             
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=k8 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/calculate/share/distfiles"
FEATURES="assume-digests ccache distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms strict unmerge-logs userfetch"
GENTOO_MIRRORS="http://mirrors.relaxdom.net/gentoo/distfiles http://mirror.yandex.ru/gentoo-distfiles http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="ru_RU.UTF-8"
LDFLAGS="-Wl,-O1"
LINGUAS="ru en"
MAKEOPTS="-j3"
PKGDIR="/usr/calculate/share/packages/CLD/9.7/x86_64"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/kde-testing /usr/local/portage/layman/sunrise /usr/local/portage/layman/desktop-effects /usr/local/portage/layman/qting-edge /usr/local/portage/layman/nx /usr/local/portage/maximka"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X a52 aac aalib acl acpi ads alsa amd64 apache2 apm audiofiee avi berkdb bittorrent bluetooth branding bzip2 cairo cddb cdparanoia cdr chm clamav cleartype cli consolekit cracklib crypt cups dbus directfb djvu dri dts dv dvd dvdr dvdread ebook emboss encode evo exif expat fam fbcon ffmpeg firefox firefox3 flac flash foomaticdb fortran ftp gd gdbm ggi gif gphoto2 gpm hal iconv icu id3tag ieee1394 imagemagick irc jabber java java6 jingle jpeg jpeg2k kde kde4 kerberos ldap libcaca libwww lirc logrotate lzo mad matroska mbox melt mikmod mmx mmxext mng modules mozilla mp3 mp4 mpeg mpi mplayer mudflap multilib musepack mysql nas ncurses nfs nls nptl nptlonly nsplugin nvidia ogg oggvorbis openal opengl openmp openssl oscar pam pcre pdf perl php plasma png portaudio ppds pppd python qt3support qt4 quicktime rdesktop readline reflection samba samba4 scanner sdl session slang smp speex spell spl sql srt sse sse2 sse3 sse4.1 sse4.2 sse4a sse5 ssl ssse3 startup-notification svg sysfs tcpd tga theora thunar tiff tools truetype type1 unicode usb userlocales v4l v4l2 vcd vhosts vorbis webkit winbind wmf wxwindows x264 xanim xcomposite xine xinerama xml xorg xpm xulrunner xv xvid xvmc yahoo zlib" ALSA_CARDS="ca0106 emu10k1 hda-intel intel8x0 intel8x0m pcsp via82xx" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="*" ELIBC="glibc" FOO2ZJS_DEVICES="*" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="ru en" NETBEANS_MODULES="ide php cnd websvccommon dlight harness apisupport webcommon enterprise java profiler nb" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 3 Harald van Dijk (RETIRED) gentoo-dev 2009-11-01 21:12:05 UTC
*** Bug 291435 has been marked as a duplicate of this bug. ***
Comment 4 Patrick Lauer gentoo-dev 2009-11-02 20:15:29 UTC
I've been able to reproduce this bug.
Looks like the ads or samba4 useflag trigger it.
Comment 5 Marcel Greter 2009-11-03 10:44:35 UTC
Created attachment 209124 [details, diff]
use heim_general_string instead of krb5_data struct

This problem did not exist before 3.4.3. It's introduced by this samba commit:
http://gitweb.samba.org/?p=samba.git;a=commitdiff;h=704b739ad8b5441e4c84215044a77e74e54cf425

Seems to me as if the type of Realm has changed in heimdal from krb5_data to heim_general_string. I wrote a patch to fix it. But beware, my C skills are not the best and it's been quite a long time since I last wrote C. Use it at your own risk.

I also opened a bug-report upstream:
https://bugzilla.samba.org/show_bug.cgi?id=6868
Comment 6 Maxim Kraev 2009-11-05 14:08:13 UTC
patch fixed problem for me. samba-client was compiled successfully, and working fine as a domain client.
Comment 7 Sebastian Koehler 2009-11-08 16:16:44 UTC
Can confirm that. I was unable to build the package on ppc without the patch. Thanks for the quick solution.
Comment 8 Corin Goodier 2009-11-09 10:25:26 UTC
Yeah it's the ads use flag. I had samba4 already disabled and it still failed at exactly the same place. Running on amd64, 10.1.

Removing the ads use flag let it compile straight away.

I also got it to compile by adding --without-cifsupcall to the configure script...
Comment 9 Corin Goodier 2009-11-09 11:14:12 UTC
Created attachment 209720 [details, diff]
Ebuild for samba-client-3.4.3 with cifs_upcall.c patch
Comment 10 Corin Goodier 2009-11-09 11:15:14 UTC
Created attachment 209722 [details, diff]
samba-3.4.3-cifs_upcall_c.patch file modified for ebuild/src tree

These two files now work in the emerge process!
Comment 11 Thomas Raschbacher gentoo-dev 2009-11-13 14:15:25 UTC
I believe bug #292195 is also related .. should it be added as a dependency for this - or vice-versa?
Comment 12 HTS 2009-11-16 23:50:45 UTC
patch works here too. Please include.
Comment 13 Marcel Greter 2009-11-24 14:22:54 UTC
Bug has been marked as fixed by upstream.
I hope it will be included in the next samba 3.4 release.
https://bugzilla.samba.org/show_bug.cgi?id=6868
Comment 14 Patrick Lauer gentoo-dev 2010-01-07 20:12:34 UTC
3.4.4 is in the tree, please test and reopen if the error persists