Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 291332 - sys-boot/grub-1.97: apply patch to quieten grub a bit more via optional parameters in grub.cfg
Summary: sys-boot/grub-1.97: apply patch to quieten grub a bit more via optional param...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-31 17:15 UTC by hal
Modified: 2009-11-01 20:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ubuntu/debian patch to quieten grub (grub-1.97-quiet.patch,2.62 KB, patch)
2009-10-31 17:20 UTC, hal
Details | Diff
ubuntu/debian patch to really quieten grub (also remove booting xyz msg (955_really_quiet.diff,2.08 KB, patch)
2009-10-31 19:12 UTC, hal
Details | Diff
adjusted debian/ubuntu patch for usage within gentoo (grub-1.97-quietboot.patch,2.31 KB, patch)
2009-11-01 13:40 UTC, hal
Details | Diff
patch to enable the quietboot patch placed in files (grub-1.97.ebuild.patch,394 bytes, patch)
2009-11-01 13:43 UTC, hal
Details | Diff
patch to enable the quietboot patch placed in files within the ebuild (grub-1.97.ebuild.patch,388 bytes, patch)
2009-11-01 15:29 UTC, hal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hal 2009-10-31 17:15:03 UTC
hello,

grub-1.97 has no possibility to quieten it completely. right after choosing a kernel to boot it would echo a message like "Booting kernel-xyz"  [Linux-bzImage, setup=0x2e00, size=0x283870] + info about initrd when available.
if someone uses a fbsplash the boot process is not really streamlined, because it gets interrupted for a short moment by grub's echo. 
i found a patch at ubuntu launchpad, that would allow to suppress these echoes with optional parameters in grub.cfg.

the patch can be found here: 
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/lucid/grub2/lucid/annotate/head%3A/debian/patches/956_linux_quiet.diff

 found at http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/lucid/grub2/lucid/annotate/head%3A/debian/patches/956_linux_quiet.diff

Reproducible: Always

Steps to Reproduce:
1. select kernel in grub's menu
2. press enter to boot the kernel


Actual Results:  
grub's echoes appear

Expected Results:  
don't show echoes

i already tried to apply the patch by myself in a local overlay. but i didn't get it to work like it should. patching fails. maybe someone with some more knowledge about ebuilding could fix that.
Comment 1 hal 2009-10-31 17:20:57 UTC
Created attachment 208875 [details, diff]
ubuntu/debian patch to quieten grub

i guess the patch and the patching procedure has to be adjusted for usage within gentoo. i tried to fix paths within the patch, but that didn't lead me to any successful results. the patch was applied partially.
Comment 2 hal 2009-10-31 19:12:18 UTC
Created attachment 208891 [details, diff]
ubuntu/debian patch to really quieten grub (also remove booting xyz msg
Comment 3 hal 2009-11-01 13:40:20 UTC
Created attachment 208949 [details, diff]
adjusted debian/ubuntu patch for usage within gentoo

tested the patch in my local overlay and it works fine so far. "quiet=1" disables any grub messages, but not the "booting menu entry" message.
Comment 4 hal 2009-11-01 13:43:58 UTC
Created attachment 208951 [details, diff]
patch to enable the quietboot patch placed in files

this patch adds a new epatch line into the ebuild to use the quietboot patch placed in the files dir of sys-boot/grub
Comment 5 hal 2009-11-01 13:45:55 UTC
comment #3 and #4 represent a solution for gentoo based on ubuntus/debians grub-1.97-quiet.patch
Comment 6 hal 2009-11-01 13:47:00 UTC
Comment on attachment 208875 [details, diff]
ubuntu/debian patch to quieten grub

commebt #3 and #4 show a solution based on this ubunto/debian patch
Comment 7 hal 2009-11-01 13:49:19 UTC
next step is to integrate just a part of 955_really_quiet.diff  into grub-1.97-quietboot.patch to have the possibility to set quiet=2. this setting would suppress all messages including "booting xyz", while quiet=1 would show the booting msg, quiet=0 shows everything
Comment 9 hal 2009-11-01 15:21:17 UTC
Comment on attachment 208891 [details, diff]
ubuntu/debian patch to really quieten grub (also remove booting xyz msg

http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/lucid/grub2/lucid/annotate/head%3A/debian/patches/955_really_quiet.diff
Comment 10 hal 2009-11-01 15:26:15 UTC
Comment on attachment 208951 [details, diff]
patch to enable the quietboot patch placed in files

patch fails due to a "typo"
Comment 11 hal 2009-11-01 15:29:36 UTC
Created attachment 208954 [details, diff]
patch to enable the quietboot patch placed in files within the ebuild

- fixed typo
- adds new line for epatch into the ebuild
Comment 12 SpanKY gentoo-dev 2009-11-01 19:50:50 UTC
grub-2 is under active development and i cant imagine changes like this have a hard time getting merged -- just like the patch author notes in 956_linux_quiet.diff.  i'm not interested in maintaining another huge patchset for grub-2.

get things moving upstream and then we'll review what is left

in the mean time, ive enabled site-specific patch support so you can easily put these patches in your own /etc/portage/patches/ tree
Comment 13 hal 2009-11-01 20:17:13 UTC
(In reply to comment #12)
> grub-2 is under active development and i cant imagine changes like this have a
> hard time getting merged -- just like the patch author notes in
> 956_linux_quiet.diff.  i'm not interested in maintaining another huge patchset
> for grub-2.
> 
> get things moving upstream and then we'll review what is left
> 
> in the mean time, ive enabled site-specific patch support so you can easily put
> these patches in your own /etc/portage/patches/ tree
> 

ok, i understand that.
i never noticed the possibility to use /usr/portage/patches/category/application for applying patches. sound nice to me, since this would make life easier to play around with patches. until now i used to use local overlays. but i guess the ebuild has to be told to look at /usr/portage/patches, right!?