Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 290991 - Missing restriction in "edit attachment as comment" -- was "Cannot edit attachments of bugz anymore"
Summary: Missing restriction in "edit attachment as comment" -- was "Cannot edit attac...
Status: RESOLVED LATER
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Bugzilla (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Bugzilla Admins
URL: https://bugs.gentoo.org/attachment.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 09:15 UTC by Justin Lecher (RETIRED)
Modified: 2011-10-30 23:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cgtest.c (cgtest.c,111 bytes, text/plain)
2009-10-30 13:11 UTC, Christian Ruppert (idl0r)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2009-10-29 09:15:53 UTC
If try to edit a bugz attachment by clicking on the "Details" link, the new window tells me

The attachment is not viewable in your browser due to security restrictions enabled by Bugzilla.

In order to view the attachment, you first have to download it.

What is going on there?
It happens with every attachment I tested.
First I discovered it with the attachment on bug 290626.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2009-10-29 09:18:32 UTC
I have to mention, I tried midori and ff

Useragents are:

Midori/0.2.0 (X11; Linux i686; U; en-gb) WebKit/532.1+

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3) Gecko/20091026 Gentoo Firefox/3.5.3

few can confirm it.
Comment 2 Christian Ruppert (idl0r) gentoo-dev 2009-10-29 23:21:57 UTC
Thanks guys, fixed.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2009-10-30 08:15:28 UTC
Sorry, isn't fixed here. I locked out and in again, but still cannot edit it.
Comment 4 Christian Ruppert (idl0r) gentoo-dev 2009-10-30 13:11:50 UTC
Created attachment 208733 [details]
cgtest.c

test
Comment 5 Christian Ruppert (idl0r) gentoo-dev 2009-10-30 13:12:44 UTC
Comment on attachment 208733 [details]
cgtest.c

>/* gcc -Wall cgtest.c -lCg */
>
>char cgCreateProgram ();
>
>int main()
>{
>	return cgCreateProgram ();
>	return 0;
>}

*test edit attachment as comment
Comment 6 Justin Lecher (RETIRED) gentoo-dev 2009-11-03 07:20:21 UTC
Some updates what the situation is about.
I can display the attachment everywhere as plain text as log the mime types are correctly handled by the browser.

At home I can also edit the attachment via Details link. If I try to do the same with my netbook which worked at home, at work it doesn't work and the reported issue comes up.

I get my network settings per dhcp and I am not using a proxy at work.
It doesn't depend on which OS or browser I use, from work I cannot edit bugs.

JS is working as proved by the reply links and igoogle.

As my netbook is okay at home, but shows the issue at work, it must be location dependend. My browser reports the issue from home, so it isn't only my work location. I will try my netbook there and report back.
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-11-03 18:49:50 UTC
(In reply to comment #6)
> At home I can also edit the attachment via Details link. If I try to do the
> same with my netbook which worked at home, at work it doesn't work and the
> reported issue comes up.
NOBODY should be getting the edit attachment in that page. If you think you can get it, I suspect browser cache, so please refresh and see.

> I get my network settings per dhcp and I am not using a proxy at work.
> It doesn't depend on which OS or browser I use, from work I cannot edit bugs.
You cannot leave any comments on bugs from work or edit bugs you filed? Can you tell me the IP that you'd be coming from then, so I can grep in the logs and see if any POST requests are making it to Bugzilla.
Comment 8 Justin Lecher (RETIRED) gentoo-dev 2009-11-03 19:16:39 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > At home I can also edit the attachment via Details link. If I try to do the
> > same with my netbook which worked at home, at work it doesn't work and the
> > reported issue comes up.
> NOBODY should be getting the edit attachment in that page. If you think you can
> get it, I suspect browser cache, so please refresh and see.

I can "edit attachment as comment". That's what I mean.

> 
> > I get my network settings per dhcp and I am not using a proxy at work.
> > It doesn't depend on which OS or browser I use, from work I cannot edit bugs.
> You cannot leave any comments on bugs from work or edit bugs you filed? Can you
> tell me the IP that you'd be coming from then, so I can grep in the logs and
> see if any POST requests are making it to Bugzilla.
> 

It is 134.94.85.9.
You also can ping on irc for a quicker reaction.
Comment 9 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-11-03 19:49:35 UTC
Ok, both sides are consistent again.
The edit-attachment will be coming back later, but only for text/plain.