Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 290827 - x11-misc/x11vnc sources lack proper inclusion of XShm headers.
Summary: x11-misc/x11vnc sources lack proper inclusion of XShm headers.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Sven Wegener
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-28 00:22 UTC by Wolfgang Draxinger
Modified: 2009-11-06 22:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Simple patch, adding the required includes (x11vnc_shm-headers.patch,306 bytes, patch)
2009-10-28 00:23 UTC, Wolfgang Draxinger
Details | Diff
patch fix against x11vnc-0.9.8 ebuild for local overlay (x11vnc-0.9.8-shm-fix.patch,2.16 KB, patch)
2009-11-06 02:26 UTC, Fabiano
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Draxinger 2009-10-28 00:22:28 UTC
The sources of x11-misc/x11vnc rely on an old structuring of X11 header files. Since recent version of X.Org building of vanilla x11vnc fails. This can be fixed by adding the proper includes. Patch is attached.
Comment 1 Wolfgang Draxinger 2009-10-28 00:23:44 UTC
Created attachment 208467 [details, diff]
Simple patch, adding the required includes
Comment 2 Oliver Sloss 2009-11-02 10:53:47 UTC
if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I..  -D_REENTRANT       -march=native -O2 -pipe -fomit-frame-pointer -msse3 -Wall -MT x11vnc-cursor.o -MD -MP -MF ".deps/x11vnc-cursor.Tpo" -c -o x11vnc-cursor.o `test -f 'cursor.c' || echo './'`cursor.c; \
        then mv -f ".deps/x11vnc-cursor.Tpo" ".deps/x11vnc-cursor.Po"; else rm -f ".deps/x11vnc-cursor.Tpo"; exit 1; fi
cleanup.c: In function âXerrorâ:
cleanup.c:288: error: âX_ShmAttachâ undeclared (first use in this function)
cleanup.c:288: error: (Each undeclared identifier is reported only once
cleanup.c:288: error: for each function it appears in.)
cleanup.c: In function âcrash_shellâ:
cleanup.c:471: warning: ignoring return value of âsystemâ, declared with attribute warn_unused_result
cleanup.c:477: warning: ignoring return value of âsystemâ, declared with attribute warn_unused_result
make[3]: *** [x11vnc-cleanup.o] Error 1
make[3]: *** Waiting for unfinished jobs....

---------------------------------------------------------

compile works after changing x11vnc-cleanup.o line 288 "X_shm.." to "Xshm.."
Comment 3 Wolfgang Draxinger 2009-11-02 14:52:32 UTC
> compile works after changing x11vnc-cleanup.o line 288 "X_shm.." to "Xshm.."

Applying my patch also fixes the problem, but leaves the identifier intact X_Shm... != Xshm on a deeper level of the X.org sources.

Just my 2 cents.
Comment 4 Fabiano 2009-11-06 02:26:18 UTC
Created attachment 209384 [details, diff]
patch fix against x11vnc-0.9.8 ebuild for local overlay

to apply this patch to a local overlay (supposing you have it in PORTDIR_OVERLAY=/usr/local/portage and saved the patch to /root/x11vnc-0.9.8-shm-fix.patch):

cd /usr/portage/
cp -p --parents x11-misc/x11vnc/x11vnc-0.9.8.ebuild /usr/local/portage/
cd /usr/local/portage/x11-misc/x11vnc
patch -p1 < /root/x11vnc-0.9.8-shm-fix.patch

ebuild x11vnc-0.9.8.ebuild compile
Comment 5 Fabiano 2009-11-06 02:30:06 UTC
My patch to the ebuild includes a patch to x11vnc.h, that is practically the same sent by Wolfgang Draxinger (thanks).
Comment 6 Sven Wegener gentoo-dev 2009-11-06 22:11:43 UTC
thanks, commited.