Bug 289875 – sys-process/iotop should DEPEND dev-python/setuptools and not bundle its own copy

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Kent Fredric (IRC: kent\n) (RETIRED) 2009-10-20 15:20:26 UTC]

in setup.py, this is present: 
sys.path.insert(0, 'setuptools-0.6c9-py2.4.egg')

as is the .egg.




Reproducible: Always

Steps to Reproduce:

[Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) 2009-10-20 15:21:09 UTC]

Created attachment 207680 [details]
patched iotop-0.3.2-r1.ebuild

[Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) 2009-10-20 15:21:35 UTC]

Created attachment 207682 [details, diff]
setuptools.patch

[Comment 3 Kent Fredric (IRC: kent\n) (RETIRED) 2009-10-20 15:28:13 UTC]

Created attachment 207685 [details]
paludis --info =sys-process/iotop-0.3.2

I might also note, for detail, that this is sort of necessary to build vs python 3.1, as the bundled copy of setuptools can't work on 3.1.

Granted, at this stage iotop doesn't work on 3.1 either, but that's a different bug =)

[Comment 4 Johan Bergström 2009-10-28 15:36:47 UTC]

Created attachment 208534 [details]
iotop-0.3.2-r1.ebuild

Hey, your changes look sane to me. I did some minor changes to your ebuild:
 - exit if kernel lacks options - the app bails just as well, no point to install it?
 - minor cleanups

Does this work on python 3.x? If so, we should let portage know (even more minor changes :)

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2009-10-30 04:02:53 UTC]

Thanks Kent, applied mainly as-is with a few small style changes.

(In reply to comment #4)
>  - exit if kernel lacks options - the app bails just as well, no point to
> install it?

See bug 287565 for why this is wrong.

Thanks.