Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 289717 - qmpdclient-1.1.2-r1 missing translations
Summary: qmpdclient-1.1.2-r1 missing translations
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-19 13:32 UTC by Yevgeny Filatov
Modified: 2010-01-14 11:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix translation install (qmpdclient-1.1.1-r1.ebuild,2.96 KB, text/plain)
2009-10-19 13:38 UTC, Yevgeny Filatov
Details
fixed ebuild (qmpdclient-1.1.1-r1.diff,1.29 KB, patch)
2009-10-22 17:27 UTC, Markos Chandras (RETIRED)
Details | Diff
fix creating empty folder /usr/share/QMPDClient/translation after install (fix_translation_folder_name.diff,444 bytes, patch)
2009-10-26 07:15 UTC, Yevgeny Filatov
Details | Diff
qmpdclient-1.1.2-r1 fix translations install (qmpdclient-1.1.2-r2.diff,749 bytes, patch)
2010-01-14 05:19 UTC, Yevgeny Filatov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yevgeny Filatov 2009-10-19 13:32:26 UTC
In version 1.1.1 changed qmpdclient.pro
After qmake Makefile contain targets "translate" and "install_translate".
Translate do only lupdate, install_translate do lrelease.
In version 1.1.0 was only "translate" target which do lupdate and lrelease.
Also in qmpdclient.1.1.1.ebuild changed variables LANGS and LANGSLONG, but in
install translations this fail to take into account

Reproducible: Always
Comment 1 Yevgeny Filatov 2009-10-19 13:38:32 UTC
Created attachment 207548 [details]
fix translation install
Comment 2 Yevgeny Filatov 2009-10-19 13:52:18 UTC
Also supplemented fix installation folder name
and fixed user's config folder name
Comment 3 Ben de Groot (RETIRED) gentoo-dev 2009-10-21 23:54:14 UTC
A diff to the existing ebuild would be preferred.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2009-10-22 17:25:57 UTC
(In reply to comment #2)
> Also supplemented fix installation folder name
> and fixed user's config folder name
> 

This shoulds like an upstream problem ( even though I dont get it ). If so please contact the upstream developers
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2009-10-22 17:27:19 UTC
Created attachment 207919 [details, diff]
fixed ebuild
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2009-10-22 18:28:11 UTC
Committed 

Closing

Thanks for reporting it
Comment 7 Yevgeny Filatov 2009-10-26 07:15:47 UTC
Created attachment 208284 [details, diff]
fix creating empty folder /usr/share/QMPDClient/translation after install

After emerging created 2 folders
/usr/share/QMPDClient/translations
/usr/share/qmpdclient/translations
first folder is empty

my patch solve this bug.
Comment 8 Yevgeny Filatov 2009-10-26 07:24:10 UTC
Comment on attachment 208284 [details, diff]
fix creating empty folder /usr/share/QMPDClient/translation after install

emty folder /usr/share/QMPDClient/translation after install
Comment 9 Yevgeny Filatov 2009-10-26 07:25:56 UTC
empty folder /usr/share/QMPDClient/translation after install
Comment 10 Markos Chandras (RETIRED) gentoo-dev 2009-10-28 06:11:26 UTC
(In reply to comment #9)
> empty folder /usr/share/QMPDClient/translation after install
> 

Fixed. Thanks for the patch:)

+*qmpdclient-1.1.1-r2 (28 Oct 2009)
+
+  28 Oct 2009; Markos Chandras <hwoarang@gentoo.org>
+  -qmpdclient-1.1.1-r1.ebuild, +qmpdclient-1.1.1-r2.ebuild:
+  Remove empty installation directory. Fixes bug 289717. Thanks to Yevgeny
+  Filatov <itspec.ru@gmail.com>
+
Comment 11 Yevgeny Filatov 2010-01-14 05:15:26 UTC
In 1.1.2-r1 variable LANGSNOLONG was renamed to LANGSLONG.
Also missed code:

for X in ${LANGSNOLONG}; do
       IUSE="${IUSE} linguas_${X%_*}"
done

for X in ${LANGS};do
       IUSE="${IUSE} linguas_${X}"
done
Comment 12 Yevgeny Filatov 2010-01-14 05:19:36 UTC
Created attachment 216452 [details, diff]
qmpdclient-1.1.2-r1 fix translations install
Comment 13 Ben de Groot (RETIRED) gentoo-dev 2010-01-14 11:26:45 UTC
That code wasn't missing, it has been moved to qt4-r2.eclass. The problem was that the var in src_install wasn't renamed. Fixed now. Thanks for reporting!