Icecat's "About" window is broken for non-English locales. I installed support for German, Japanese and English and tested with de_DE.UTF-8, ja_JP.UTF-8, en_US.UTF-8 and C locale settings. The de_DE.UTF-8 and ja_JP.UTF-8 locales show the same behavior: When clicking the "About" entry in the "Help" menu, the appearing window contains an error message from the XML-parser. The German one looks like this: XML-Verarbeitungsfehler: Nicht definierte Entität Adresse: chrome://browser/content/aboutDialog.xul Zeile Nr. 40, Spalte 9: &logoCopyright; --------^ As I can't to reproduce the error with English locale settings, I'm unable to provide an English error message. Typing "about:" in the location bar works in any locale. Below my attempt to translate the error message to English: XML-Parser error: Undefined entity Location: chrome://browser/content/aboutDialog.xul Row 40, Column 9: &logoCopyright; --------^
icecat hit main Portage tree, but the bug persists. Confirmed on ru_RU-system
(In reply to comment #1) > icecat hit main Portage tree, but the bug persists. > Confirmed on ru_RU-system > I am aware of the bug and will continue to work on it.
Confirming for pl_PL.UTF-8 Comes from missing ENTITY definition in locale/browser/aboutDialog.dtd in ${lang}.jar for logoCopyright - for en_US it's simply: <!ENTITY logoCopyright ""> Once added, dialog shows correctly.
Confirmed for ru_RU locale
Confirmed on it_IT locale.
The reason for this bug is obvious: in src_prepare, block starting with "for X in ${linguas}; do" has been simplified too much, when compared to http://gnuzilla.gnu.org/download/langpacks/IceCatTranslate-0.1.py On the other hand, that script seems to do bit too much for Gentoo. A balance needs to be found.
Downloading the rebranded Icecat xpi files instead of the Firefox ones, and dropping the ebuild's own rebranding seems like the simplest solution, but... (In reply to comment #6) > On the other hand, that script seems to do bit too much for Gentoo. > A balance needs to be found. do you really mean it does too much, or just that it does too much to be suitable for an ebuild? If the former, those xpis shouldn't be used, but if the latter, then that's not a problem since it wouldn't be done from the ebuild.
What I'm really disagreeing about is the current icecat ebuild. Over 99% of the code is the same between firefox and icecat tarballs, yet we're still using separate tarballs. Sure, doing it another way would require a bit more work from the maintainer for the first time, but we could simply add a little git repository with produced icons and later just update it with changes from gnuzilla svn. That would reduce bandwidth for both mirrors and icecat users by nearly a half, as firefox tarball is needed any way for xulrunner. As for the script, you should notice, that among other, it downloads the requested xpi file from mozilla mirror. I would drop (or reduce to english only) that part which differs between locales, even though my language surprisingly is there.
(In reply to comment #8) > What I'm really disagreeing about is the current icecat ebuild. > Over 99% of the code is the same between firefox and icecat tarballs, > yet we're still using separate tarballs. The problem with that isn't that firefox and icecat use different tarballs, but that firefox and xulrunner use the same tarball, and icecat follows firefox. If a newer standalone xulrunner is released (and there's an open upstream bug about it), then it might be possible to drop the xulrunner bits from the firefox and icecat tarballs, so that they would be significantly smaller. > [...] > As for the script, you should notice, that among other, > it downloads the requested xpi file from mozilla mirror. > > I would drop (or reduce to english only) that part which > differs between locales, even though my language surprisingly > is there. The "Modified by"? Sure, that's not necessary, but if that's all, the xpi files created by it seem fine, so it would be just as easy to just download those directly.
Harald feel free to fix any bugs that arise for icecat, I am extremely busy with other tasks at the moment.
Sure, done.
