Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 288706 - >=gnome-extra/gnome-screensaver-2.26.1 ignores "gnome-screensaver-command -p"
Summary: >=gnome-extra/gnome-screensaver-2.26.1 ignores "gnome-screensaver-command -p"
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
: 352997 (view as bug list)
Depends on:
Blocks: gnome2.26
  Show dependency tree
 
Reported: 2009-10-12 09:44 UTC by peng shao
Modified: 2011-02-07 12:44 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch I found for ubuntu gnome-screensaver-2.28.0 (gnome-screensaver-2.26.1-poke.patch,871 bytes, text/plain)
2009-10-12 09:45 UTC, peng shao
Details
10_legacy_scrsvr_inhibit.patch (10_legacy_scrsvr_inhibit.patch,3.96 KB, patch)
2010-01-04 11:31 UTC, Pacho Ramos
Details | Diff
Reintroduce legacy API for inhibiting the screensaver (10_legacy_scrsvr_inhibit.patch,996 bytes, patch)
2011-02-07 11:43 UTC, poncho
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peng shao 2009-10-12 09:44:07 UTC
When I tried to poke gnome-screensaver by "gnome-screensaver-command -p", I noticed that the debugging gnome-screensaver(launched by gnome-screensaver --no-daemon --debug) gives out

[gs_debug_init] gs-debug.c:106 (05:23:31):	 Debugging enabled
[main] gnome-screensaver.c:87 (05:23:31):	 initializing gnome-screensaver 2.26.1
[init_session_id] gs-listener-dbus.c:1986 (05:23:31):	 Got session-id: /org/freedesktop/ConsoleKit/Session23
[gs_fade_init] gs-fade.c:689 (05:23:31):	 Fade type: 2
[set_status] gs-watcher-x11.c:345 (05:23:31):	 GSWatcher: not active, ignoring status changes
[gs_watcher_set_active] gs-watcher-x11.c:275 (05:23:31):	 turning watcher: ON
[listener_dbus_handle_system_message] gs-listener-dbus.c:1411 (05:23:31):	 obj_path=/org/freedesktop/DBus interface=org.freedesktop.DBus method=NameAcquired destination=:1.824
[listener_dbus_handle_system_message] gs-listener-dbus.c:1411 (05:23:31):	 obj_path=(null) interface=(null) method=(null) destination=:1.824
[listener_dbus_handle_system_message] gs-listener-dbus.c:1411 (05:23:31):	 obj_path=(null) interface=(null) method=(null) destination=:1.824
[listener_service_deleted] gs-listener-dbus.c:1049 (05:23:31):	 DBUS service deleted: 
[listener_dbus_handle_system_message] gs-listener-dbus.c:1411 (05:23:31):	 obj_path=(null) interface=(null) method=(null) destination=:1.824
[listener_service_deleted] gs-listener-dbus.c:1049 (05:23:31):	 DBUS service deleted: 
[listener_dbus_handle_system_message] gs-listener-dbus.c:1411 (05:23:31):	 obj_path=(null) interface=(null) method=(null) destination=:1.824
[on_bg_changed] gs-manager.c:948 (05:23:31):	 background changed
[listener_service_deleted] gs-listener-dbus.c:1049 (05:23:34):	 DBUS service deleted: 
[gs_manager_request_unlock] gs-manager.c:1782 (05:23:34):	 Request unlock but manager is not active
[listener_service_deleted] gs-listener-dbus.c:1049 (05:23:34):	 DBUS service deleted: :1.72

(Also some strange behavior of gnome-screensaver-2.26.1 has been observed: sometimes for unknown reason it failed to detect Idle notice signal when the supposed time is coming. But I am not sure it has anything to do with this bug, please ignore this behavior if you think it is not a good idea to include it into this bug report, and I will continue to observe until I have a better idea what is wrong)


Also there is a similar bug report for ubuntu at 
https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/437519
I tried their patch, but did not work for me. For reference reason I also included that patch in this bug report and wish the gentoo developers may kindly test it. I am a rookie in gentoo, so maybe I patched it incorrectly. I did not modify the ubuntu patch at all for reference, but perhaps you should modify the patch's header from 

--- gs-monitor.c ....
+++gs-monitor.c ..

to

---src/gs-monitor.c
+++src/gs-monitor.c

By this I could successfully emerge the patched gnome-screensaver-2.26.1, but the debugging message remains the same. I have no idea why.

As a comparison, I tested gnome-screensaver-2.24.1-r1, it works normally:
[listener_service_deleted] gs-listener-dbus.c:1043 (05:37:50):	 DBUS service deleted: 
[gs_watcher_set_active] gs-watcher-x11.c:731 (05:37:50):	 turning watcher: OFF
[_gs_watcher_set_active_internal] gs-watcher-x11.c:714 (05:37:50):	 Stopping idle watcher
[gs_watcher_set_active] gs-watcher-x11.c:731 (05:37:50):	 turning watcher: ON
[_gs_watcher_set_active_internal] gs-watcher-x11.c:718 (05:37:50):	 Starting idle watcher
[gs_manager_request_unlock] gs-manager.c:1781 (05:37:50):	 Request unlock but manager is not active
[listener_service_deleted] gs-listener-dbus.c:1043 (05:37:50):	 DBUS service deleted: :1.83

[gs_manager_request_unlock] gs-manager.c:1781 (05:37:50):	 Request unlock but manager is not active




Reproducible: Always

Steps to Reproduce:
1. run debugging gnome-screensaver by gnome-screensaver --no-daemon --debug
2. run gnome-screensaver-command -p in another terminal
3.

Actual Results:  
See my description

Expected Results:  
The idle watcher is reset.

Portage 2.1.6.13 (default/linux/amd64/2008.0/desktop, gcc-4.4.1, glibc-2.10.1-r0, 2.6.31-gentoo-r1 x86_64)
=================================================================
System uname: Linux-2.6.31-gentoo-r1-x86_64-Intel-R-_Core-TM-2_Duo_CPU_E8400_@_3.00GHz-with-gentoo-2.0.1
Timestamp of tree: Sat, 10 Oct 2009 16:00:18 +0000
ccache version 2.4 [enabled]
app-shells/bash:     4.0_p33
dev-java/java-config: 2.1.9-r1
dev-lang/python:     2.4.4-r13, 2.6.3, 3.1.1-r1
dev-python/pycrypto: 2.0.1-r8
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.6.4-r3
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.5.1
sys-apps/sandbox:    2.1
sys-devel/autoconf:  2.13, 2.63-r1
sys-devel/automake:  1.5, 1.7.9-r1, 1.9.6-r2, 1.10.2, 1.11
sys-devel/binutils:  2.19.1-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nocona -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://www.cyberuse.com/gentoo/ "
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 avahi bash-completion berkdb bluetooth branding bzip2 cairo cdr cli consolekit cracklib crypt cups dbus dri dts dvd dvdr eds emboss encode esd evo fam firefox flac fortran gdbm gif gnome gpm gstreamer gtk hal iconv isdnlog jpeg ldap libnotify mad mikmod mmx modules mp3 mp4 mpeg mudflap multilib ncurses nls nptl nptlonly ogg opengl openmp pam pcre pdf perl png policykit ppds pppd python qt3support quicktime readline reflection sdl session spell spl sse sse2 ssl startup-notification svg sysfs tcpd thunar tiff truetype unicode usb vim-syntax vorbis x264 xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ice1712" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS


related package information

[ebuild   R   ] x11-proto/scrnsaverproto-1.1.0  0 kB
[ebuild   R   ] sys-auth/consolekit-0.3.0-r2  USE="pam policykit -debug -doc" 0 kB
[ebuild   R   ] sys-apps/dbus-1.3.0  USE="X -debug -doc (-selinux) -test" 0 kB
[ebuild   R   ] x11-libs/libXScrnSaver-1.1.3  USE="-debug" 0 kB
[ebuild   R   ] x11-base/xorg-server-1.6.4  USE="hal nptl sdl xorg -debug -dmx -ipv6 -kdrive -minimal -tslib" 0 kB
[ebuild   R   ] gnome-extra/gnome-screensaver-2.24.1-r1  USE="libnotify opengl pam -debug -doc" 0 kB
Comment 1 peng shao 2009-10-12 09:45:43 UTC
Created attachment 206847 [details]
patch I found for ubuntu gnome-screensaver-2.28.0

This patch did not work for me, but perhaps you are willing to test it by yourselves because I might have made any stupid mistakes. Thanks. I did not check the box for patch, because it is not a confirmed patch sorry for that.
Comment 2 Bryan Green 2009-12-18 17:37:20 UTC
I don't think you are imagining the occasional missing of idle timeouts.
I'm seeing the same thing on a couple systems with gnome-screensaver-2.26.1.
Bug 295227 seems related to that issue.
Comment 3 Pacho Ramos gentoo-dev 2010-01-04 11:27:28 UTC
Looks similar to:
https://bugzilla.gnome.org/show_bug.cgi?id=579430
Comment 4 Pacho Ramos gentoo-dev 2010-01-04 11:31:18 UTC
Created attachment 215154 [details, diff]
10_legacy_scrsvr_inhibit.patch

This is the patch currently used by ubuntu, but it hasn't been accepted by upstream yet :-/
Comment 5 peng shao 2010-01-04 16:42:43 UTC
(In reply to comment #4)
> Created an attachment (id=215154) [details]
> 10_legacy_scrsvr_inhibit.patch
> 
> This is the patch currently used by ubuntu, but it hasn't been accepted by
> upstream yet :-/
> 

Thank you guys :) I will test the patch 
Comment 6 peng shao 2010-01-06 08:23:21 UTC
I could not see any difference from the debug information after I applied the patch... 

Comment 7 Pacho Ramos gentoo-dev 2010-01-06 13:32:34 UTC
(In reply to comment #6)
> I could not see any difference from the debug information after I applied the
> patch... 
> 

And, is screensaver still being activated when viewing a movie with mplayer/vlc and trying to prevent it running gnome-screensaver -p ? (seems that it's the effect seen by people suffering this removal during 2.24 -> 2.26 update)
Comment 8 peng shao 2010-01-06 18:19:21 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > I could not see any difference from the debug information after I applied the
> > patch... 
> > 
> 
> And, is screensaver still being activated when viewing a movie with mplayer/vlc
> and trying to prevent it running gnome-screensaver -p ? (seems that it's the
> effect seen by people suffering this removal during 2.24 -> 2.26 update)
> 

I did several tests from mplayer and with a sleep command, and by now it seems to be working like a charm, and very unlikely it would fall into trouble again.  I looked into the discussion of gnome bugzilla and it looks like this patch is only a workaround since it is not the original way gnome-screensaver to realize the poke, isn't it? At least it could not give the expected debug information. I don't know when the mainstream will accept it and even if they will accept it at all, but it is working for end-users. 
Comment 9 Pacho Ramos gentoo-dev 2010-01-06 18:32:32 UTC
(In reply to comment #8)
>  I looked into the discussion of gnome bugzilla and it looks like this patch is
> only a workaround since it is not the original way gnome-screensaver to realize
> the poke, isn't it? At least it could not give the expected debug information.

This is what I suspected :-)
> I don't know when the mainstream will accept it and even if they will accept it
> at all, but it is working for end-users. 
> 

OK
Comment 10 Pacho Ramos gentoo-dev 2010-01-06 18:43:22 UTC
FYI, seems that this was the (huge) commit that changed this:
http://git.gnome.org/browse/gnome-screensaver/commit/?id=403d9bed54d705253ffe5e8c8874ce97cd557d19
https://bugzilla.gnome.org/show_bug.cgi?id=444927

then, probably vlc /mplayer should be fixed instead :-/
Comment 11 peng shao 2010-01-06 19:18:18 UTC
(In reply to comment #10)
> FYI, seems that this was the (huge) commit that changed this:
> http://git.gnome.org/browse/gnome-screensaver/commit/?id=403d9bed54d705253ffe5e8c8874ce97cd557d19
> https://bugzilla.gnome.org/show_bug.cgi?id=444927
> 
> then, probably vlc /mplayer should be fixed instead :-/
> 

Hmmm, too scary for me. Looks like I have to wait for further news because now I am totally lost in this jungle of codes....And being frank if my memory serves well mplayer has a long time trouble with the screensaver :(
Comment 12 Pacho Ramos gentoo-dev 2010-01-06 20:45:10 UTC
(In reply to comment #10)
> then, probably vlc /mplayer should be fixed instead :-/
> 

after searching a bit more, seems that mplayer should work with gnome-screensaver without needing to use gnome-screensaver-command -p (and a xorg-server >1.4):
https://bugzilla.gnome.org/show_bug.cgi?id=552209#c1
http://www.libsdl.org/cgi/viewvc.cgi?revision=3558&view=revision (the interesting link is http://svn.mplayerhq.hu/mplayer?view=rev&revision=25637 , but it doesn't work now). Then, if you still needs to use gnome-screensaver-command -p with recent mplayers, I think that it's a different bug 
Comment 13 peng shao 2010-01-06 21:12:31 UTC
(In reply to comment #12)
> (In reply to comment #10)
> > then, probably vlc /mplayer should be fixed instead :-/
> > 
> 
> after searching a bit more, seems that mplayer should work with
> gnome-screensaver without needing to use gnome-screensaver-command -p (and a
> xorg-server >1.4):
> https://bugzilla.gnome.org/show_bug.cgi?id=552209#c1
> http://www.libsdl.org/cgi/viewvc.cgi?revision=3558&view=revision (the
> interesting link is http://svn.mplayerhq.hu/mplayer?view=rev&revision=25637 ,
> but it doesn't work now). Then, if you still needs to use
> gnome-screensaver-command -p with recent mplayers, I think that it's a
> different bug 
> 

I tried to remove the heart-beat command from mplayer and apparently it could not stop screensaver from launching. :(
Comment 14 Pacho Ramos gentoo-dev 2010-04-14 16:29:09 UTC
Video herd, can you please take a look on comment #12 and #13 and tell us if mplater should work or not without needing to run "gnome-screensaver -p"? Thanks a lot
Comment 15 Pacho Ramos gentoo-dev 2010-06-13 19:52:00 UTC
We cannot do much more since commented patch causes other kind of problems and this needs to be handled by upstream directly.

Sorry for the inconvenience
Comment 16 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-01-31 12:54:45 UTC
*** Bug 352997 has been marked as a duplicate of this bug. ***
Comment 17 poncho 2011-02-07 11:43:13 UTC
(In reply to comment #15)
> We cannot do much more since commented patch causes other kind of problems and
> this needs to be handled by upstream directly.
> 
> Sorry for the inconvenience
> 

New patch from https://bugzilla.gnome.org/show_bug.cgi?id=579430

This patch fixes the gnome-screensaver activation in combination with vlc.
Comment 18 poncho 2011-02-07 11:43:46 UTC
Created attachment 261709 [details, diff]
Reintroduce legacy API for inhibiting the screensaver
Comment 19 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-02-07 12:44:38 UTC
@poncho, we are not going to apply this patch, cf. upstream bug report.