Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 288589 - app-portage/gentoolkit-dev: echangelog detects some valid files as trivial
Summary: app-portage/gentoolkit-dev: echangelog detects some valid files as trivial
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 284680
  Show dependency tree
 
Reported: 2009-10-11 16:50 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2009-11-10 20:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2009-10-11 16:50:54 UTC
I bumped into this when trying to update the changelog for ExtUtils-Manifest. 

Seems the codebyte as follows thinks that that ebuild is a "trivial" change. 

# Separate out the trivial files for now
@files = grep {
	!/files.digest|Manifest|ChangeLog/ or do { push @trivial, $_; 0; }
} @files;

@unknown = grep {
	!/files.digest|Manifest|ChangeLog/ or do { push @trivial, $_; 0; }
} @unknown;

The solution I found was as follows:


# Separate out the trivial files for now
@files = grep {
	!/^(files.digest|Manifest|ChangeLog)$/ or do { push @trivial, $_; 0; }
} @files;

@unknown = grep {
	!/^(files.digest|Manifest|ChangeLog)$/ or do { push @trivial, $_; 0; }
} @unknown;


This makes sense to me for the following reasons:

1. You cant run echangelog in a parent directory, thats invalid ( thus, eliminating the need to do path checks, you'll always be in ^ )

2. You can't run echangelog in a child directory, thats invalid too ( thus letting us assume $ at the end ) 

also, ^files/Manifest would have different rules to just ^Manifest, and should even possibly be permitted.
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2009-10-11 16:51:47 UTC
This bug blocks bug 284680 , but I don't have the power to set that it seems.
Comment 2 Christian Ruppert (idl0r) gentoo-dev 2009-10-11 19:10:50 UTC
Thanks!
Fixed in svn (r688).
Comment 3 Christian Ruppert (idl0r) gentoo-dev 2009-11-10 20:34:21 UTC
Fixed in 0.2.6.13.