Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 288412 - >dev-java/swt-3.4 fails to build with new versions of xextproto (xorg-server-1.7)
Summary: >dev-java/swt-3.4 fails to build with new versions of xextproto (xorg-server-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-10 11:04 UTC by Thomas Pegeot
Modified: 2009-11-03 21:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Pegeot 2009-10-10 11:04:18 UTC
Hello,
I'm using Xorg-server-1.7 which required at least =x11-proto/xextproto-7.0.99.3. This new version of xextproto provides X11/extensions/xtestconst.h instead of X11/extensions/XTest.h, which is required by dev-java/swt to build! 

A simple patch can fix the compile failure, but this patch should be applied conditionally whether a new version of xextproto is installed or not. ;)

Thank you very much!





Reproducible: Always




Patch example : 
--- os.h        2009-10-10 12:48:25.000000000 +0200
+++ os.h.orig   2009-10-10 12:47:37.000000000 +0200
@@ -79,7 +79,7 @@                                  
                                                   
 #else                                             
 #include <gdk/gdkx.h>                             
-#include <X11/extensions/xtestconst.h>            
+#include <X11/extensions/XTest.h>                 
 #include <X11/extensions/Xrender.h>               
 #endif
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2009-10-10 11:31:02 UTC
(In reply to comment #0)
> 
> A simple patch can fix the compile failure, but this patch should be applied
> conditionally whether a new version of xextproto is installed or not. ;)
> 

Conditional patching is not acceptable if it breaks binary packages. Basically if built against the latest xextproto it should still work against older X packages. Probably the easiest option is to just require a new xextproto and always patch. x11: please give your opinion.
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2009-10-10 13:13:08 UTC
1) the new headers are still p.masked until we do further testing
2) while the headers have shifted around, the overall API and ABI is (to the best of my knowledge) unchanged

I think that for this particular case, conditional patches should be ok.

But the issue can be solved with such patches [1]

Thanks

[1] http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=0a4c4c5fe8ebad2dd13f5770bd90a194eebb2890
Comment 3 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2009-11-03 21:21:58 UTC
Looks like X11/extensions/XTest.h is now provided by libXtst and swt builds fine with it. Thus no patching needed, libXtst was already in RDEPEND, moved it also to DEPEND. The xextproto dependency also stays, so it will work with both old and new xorg.