Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 287707 - [TRACKER] Use rpm_src_unpack instead of rpm_unpack && unpack...
Summary: [TRACKER] Use rpm_src_unpack instead of rpm_unpack && unpack...
Status: CONFIRMED
Alias: None
Product: Quality Assurance
Classification: Unclassified
Component: Trackers (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords: Tracker
Depends on:
Blocks:
 
Reported: 2009-10-05 06:17 UTC by SpanKY
Modified: 2021-07-21 00:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2009-10-05 06:17:55 UTC
it looks like every net-dialup package that uses `rpm_unpack` is duplicating functionality (and in a bad way) of the rpm.eclass.  from what i can see, every ebuild that does:
    rpm_unpack "${DISTDIR}/${A}" || die "failed to unpack ${A} file"
    DISTDIR="${WORKDIR}" unpack <some tarballs>

can be changed to simply call:
    rpm_src_unpack

certainly a quick test of fcdsl seems to work:
 src_unpack() {
-   rpm_unpack "${DISTDIR}/${A}" || die "failed to unpack ${A} file"
-   DISTDIR="${WORKDIR}" unpack ${PN}-suse[0-9][0-9]-[0-9].[0-9]*-[0-9]*.tar.gz
+   rpm_src_unpack
Comment 1 Pacho Ramos gentoo-dev 2016-01-30 16:21:05 UTC
This is more like a general task tracked by QA team