Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 287504 - xdm init script improvement for x11-apps/xinit-1.0.8-r8
Summary: xdm init script improvement for x11-apps/xinit-1.0.8-r8
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-03 14:52 UTC by Enrico Tagliavini
Modified: 2009-10-06 09:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
The new init.d/xdm script (xdm.initd-4,5.23 KB, text/plain)
2009-10-03 14:53 UTC, Enrico Tagliavini
Details
The new conf.d/xdm file (xdm.confd-2,824 bytes, text/plain)
2009-10-03 14:54 UTC, Enrico Tagliavini
Details
x11-apps/xinit-1.0.8-r8.ebuild patch (xinit_needserv.patch,514 bytes, text/plain)
2009-10-03 14:55 UTC, Enrico Tagliavini
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Enrico Tagliavini 2009-10-03 14:52:52 UTC
Currently xdm is started after some not always need service
   after readahead-list ypbind openvpn gpm lircmd autofs
to be usable in all situations.

If a user doesn't needs someone of this he has to edit the file every time xinit is updated. Ok not a big problem, but this ca be done better. I've done a patch to the xdm init script that uses service listed in conf.d/xdm so configure needed services is easier for a user.

So how does my patch works? In a very simple way: 1) in conf.d/xdm i define a var like NEED_SERV="ypbind autofs openvpn gpm lircmd" that lists all services that must be started before xdm; 2) in init.d/xdm the second after line looks like this
   after readahead-list ${NEED_SERV}
that's all!

For example i use autofs to mount some remote data storage under /mnt, so nothing that xdm needs (all system folders are local), so i can just remove autofs from NEED_SERV. 

Ok the pros are only that xdm starts a bit earlier, and the init script is more flexible.

I will attach changed files in few minutes.

I hope this can be usefull, if not.... well i've tried :D

Reproducible: Always

Steps to Reproduce:
Comment 1 Enrico Tagliavini 2009-10-03 14:53:49 UTC
Created attachment 205918 [details]
The new init.d/xdm script
Comment 2 Enrico Tagliavini 2009-10-03 14:54:23 UTC
Created attachment 205919 [details]
The new conf.d/xdm file
Comment 3 Enrico Tagliavini 2009-10-03 14:55:11 UTC
Created attachment 205921 [details]
x11-apps/xinit-1.0.8-r8.ebuild patch
Comment 4 Rémi Cardona (RETIRED) gentoo-dev 2009-10-06 09:35:00 UTC
After discussing this with Enrico, we've collectively decided that this approach was not correct for the time being.

More efforts should be put on stabilizing and improving OpenRC's parallel boot support.

Such patches might be needed later on for users to fine-tune dependencies based on their configuration, but it's too early for such changes without knowing what we want to achieve.

Thanks