Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 287113 - app-misc/abook-0.5.6 0.5.6-01_editor patch incorporation
Summary: app-misc/abook-0.5.6 0.5.6-01_editor patch incorporation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Net-Mail Packages
URL: http://abook.sourceforge.net/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-30 15:54 UTC by Arseny Solokha
Modified: 2009-10-17 18:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from upstream (0.5.6-01_editor.patch,464 bytes, patch)
2009-10-02 04:06 UTC, Arseny Solokha
Details | Diff
Proposed patch (abook-0.5.6.ebuild.patch,836 bytes, patch)
2009-10-02 04:07 UTC, Arseny Solokha
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arseny Solokha 2009-09-30 15:54:48 UTC
Since abook's development is stalled for a while it seems reasonable to integrate patches released after last stable version has been made to get a really complete package before it will be dropped out from the Portage tree (hope it will not be dropped soon).
There is such post-release fix mentioned at project's main page (http://abook.sourceforge.net/patches/0.5.6-01_editor) that should be included to improve package quality.

There's also an option to extend abook's functionality by integrating vCard import patch (http://abook.sourceforge.net/patches/abook_vcard_import.patch) and introducing USE flag for it. Though, I've faced with problems merging this patch with 0.5.6 off the top of my head, so extra review for this is needed.

Reproducible: Always

Steps to Reproduce:
Comment 1 Arseny Solokha 2009-10-01 08:57:38 UTC
Jaakko Heinonen, the abook developer, confirmed that 0.6 branch prereleases should be stable enough for everyday use. He also could release security updates, but not extending the functionality.
Comment 2 Arseny Solokha 2009-10-02 04:06:35 UTC
Created attachment 205804 [details, diff]
Patch from upstream

Patch for 0.5.6 to fix a segfault bug in editor
Comment 3 Arseny Solokha 2009-10-02 04:07:30 UTC
Created attachment 205806 [details, diff]
Proposed patch

Patch for ebuild
Comment 4 Torsten Veller (RETIRED) gentoo-dev 2009-10-17 18:26:12 UTC
I've added the editor patch. Thanks for the bug.

Wrt vcard patch: I am not going to extend the functionality too.