28705 – mtime and ordering bugs in do_upgrade()

Bug 28705 - mtime and ordering bugs in do_upgrade()

Summary: mtime and ordering bugs in do_upgrade()

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Unclassified (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2003-09-14 07:21 UTC by Marius Mauch (RETIRED)
Modified:	2011-10-30 22:20 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch that resorts the list of update files (doupgrade_reorder.patch,561 bytes, patch) 2003-09-14 07:35 UTC, Marius Mauch (RETIRED)	Details \| Diff
patch for the mtime bug (fixpackages-mtime.diff,599 bytes, patch) 2003-09-18 19:15 UTC, Marius Mauch (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marius Mauch (RETIRED) gentoo-dev

2003-09-14 07:21:31 UTC

- the update files are applied in the wrong order, e.g. 1Q-2003 is applied
before 4Q-2002
- portage always uses all update files, not only the modified ones.

Comment 1 Marius Mauch (RETIRED) gentoo-dev

2003-09-14 07:35:54 UTC

Created attachment 17699 [details, diff]
patch that resorts the list of update files

Comment 2 Marius Mauch (RETIRED) gentoo-dev

2003-09-18 19:15:06 UTC

Created attachment 17959 [details, diff]
patch for the mtime bug

Comment 3 Nicholas Jones (RETIRED) gentoo-dev

2003-09-18 21:42:09 UTC

reordering, good, in cvs.
The other one isn't.

mtimes should never change, newer doesn't account for clock skew, and the
'or caller=fixpackages' is perfectly fine.

Comment 4 Marius Mauch (RETIRED) gentoo-dev

2003-09-19 13:49:07 UTC

Hm, then why does portage use all update files always? Could a nfs exported tree cause this? I can understand the caller=fixpackges condition, but it looks a bit stupid to redo all the update files on each call.