Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 286666 - media-plugins/vdr-dvd: wrong media-libs/libdvdcss (R)DEPEND
Summary: media-plugins/vdr-dvd: wrong media-libs/libdvdcss (R)DEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo VDR Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-27 13:40 UTC by Fabio Erculiani (RETIRED)
Modified: 2009-11-18 20:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vdr-dvd-0.3.7_pre20071113-r2 ebuild patch (vdr-dvd-0.3.7_pre20071113-r2.ebuild.patch,633 bytes, patch)
2009-09-27 13:46 UTC, Fabio Erculiani (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2009-09-27 13:40:56 UTC
This is a semi-automated bug report with SOLUTION (for the lazy)

- "media-libs/libdvdcss" is illegal in some countries.

- the pkg in subject contains hardcoded dependency (RDEPEND + DEPEND) against libdvdcss, which is wrong for these reasons:

  - dependency is OPTIONAL and only required at runtime
    (thus NOT a DEPEND first of all)

  - dvdcss.h header is not used at all

  - dlopen is also NOT used

  - compiling without libdvdcss.so in linker paths works hands down

  - README explicitly tells that libdvdcss is OPTIONAL even if code
    does not contain any reference to it ! (maybe outdated README?)

Please find a patched ebuild attached.

Reproducible: Always
Comment 1 Fabio Erculiani (RETIRED) gentoo-dev 2009-09-27 13:46:27 UTC
Created attachment 205380 [details, diff]
vdr-dvd-0.3.7_pre20071113-r2 ebuild patch
Comment 2 Matthias Schwarzott gentoo-dev 2009-11-18 20:47:57 UTC
vdr-dvd does not use libdvdcss directly. So there is no need for a depend of any kind.
If users want css support, they should enable USE=css, and libdvdread will then pull in libdvdcss.

Thanks for reporting this issue.