Bug 286564 – x11-terms/terminal-0.4.0 startup-notification dependency

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Darren Smith 2009-09-26 19:51:17 UTC]

Please consider this patch to remove the startup-notification dependency from x11-terms/terminal-0.4.0. The startup-notification dependency pulls in libxcb which is why I'd like to avoid it. Thanks!

Reproducible: Always

[Comment 1 Darren Smith 2009-09-26 19:52:36 UTC]

Created attachment 205334 [details]
ebuild

ebuild which adds startup-notification USE flag and patch

[Comment 2 Darren Smith 2009-09-26 19:53:42 UTC]

Created attachment 205336 [details, diff]
patch to configure script

[Comment 3 Samuli Suominen (RETIRED) 2009-09-28 06:18:50 UTC]

Needs to be reported also in Xfce4's bugzilla -> http://bugs.xfce.org

[Comment 4 Samuli Suominen (RETIRED) 2009-09-30 22:51:36 UTC]

And I suspect the patch isn't enough. What about Makefile.am's? A situation where --disable-startup-notification is passed and startup-notification is installed. Automagic linking.

Anyway, won't be applied before reporting to upstream.

[Comment 5 Darren Smith 2009-10-01 01:02:47 UTC]

(In reply to comment #4)
> And I suspect the patch isn't enough. What about Makefile.am's? A situation
> where --disable-startup-notification is passed and startup-notification is
> installed. Automagic linking.

I'm not sure what's going on, but as of now terminal-0.4.0 no longer requires startup-notification. All that needs to be done is to remove the dep from the ebuild. I don't see anywhere in the source where terminal is linked against startup-notification. Am I missing something?

[Comment 6 Samuli Suominen (RETIRED) 2009-10-02 11:32:58 UTC]

Fixed in 0.4.1, couldn't find any reference to startup-notification the source's.