Bug 286383 – x11-libs/libxcb/files/xcb-rebuilder.sh won't autorebuild broken packages

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Pacho Ramos 2009-09-25 10:38:43 UTC]

After running:
/usr/portage/x11-libs/libxcb/files/xcb-rebuilder.sh

I get a list of "* Broken packages"

I would expect that emerge would be called with "-1av" option to simply press "y" (or "n") and rebuild them.

Then, I read the script and saw that involved lines are commented:
#
#ebegin "Rebuilding broken packages"
#${XCB_REBUILDER_INSTALL:-emerge -1} ${XCB_PACKAGES}
#eend $?

Why are they commented?

Thanks

Reproducible: Always

[Comment 1 Pacho Ramos 2009-09-25 10:51:18 UTC]

Would be also interesting to be able to pass more options to emerge command (like --jobs) like revdep-rebuild allows

I am working on it

[Comment 2 Pacho Ramos 2009-09-25 11:08:41 UTC]

Created attachment 205194 [details, diff]
xcb-rebuilder.patch

This works for me when running:
./xcb-rebuilder.sh -- -1av --jobs

[Comment 3 Rémi Cardona (RETIRED) 2009-09-28 07:01:12 UTC]

NAK, the guide explains _why_ this is approach fails and why we have a guide to begin with.

Yes, xcb-rebuilder.sh is probably a bad name but really, all it does it to fix .la files and list broken packages.

THanks

[Comment 4 Pacho Ramos 2009-09-28 08:00:05 UTC]

(In reply to comment #3)
> NAK, the guide explains _why_ this is approach fails and why we have a guide to
> begin with.
> 

Sorry, but I don't see it :-(

Do you expect to get reported packages rebuilt with "revdep-rebuild -L..." then?

> Yes, xcb-rebuilder.sh is probably a bad name but really, all it does it to fix
> .la files and list broken packages.
> 

The name and also its help (shown when running "xcb-rebuilder.sh *") 

[Comment 5 Rémi Cardona (RETIRED) 2009-09-28 08:28:59 UTC]

(In reply to comment #4)
> Sorry, but I don't see it :-(

Indeed, I skipped the explanation in the final doc to make it shorter.

The reason behind the subset is circular deps. When revdep-rebuild asks portage to rebuild all broken packages, if there's a single circular dep, portage will rebuild the packages in a completely random order.

So to avoid that, we tell users to rebuild a simple subset (code listing 3.1) which breaks all common dependency loops.

> Do you expect to get reported packages rebuilt with "revdep-rebuild -L..."
> then?

No, the guide says that users should follow _reading_ if the script reports broken packages. It's all written in the guide, I'm not making it up.

> The name and also its help (shown when running "xcb-rebuilder.sh *") 

I'll make the script print out a blurb at the end to point users back to the guide for further instructions.

Thanks

[Comment 6 Pacho Ramos 2009-09-28 08:54:41 UTC]

(In reply to comment #5)

> No, the guide says that users should follow _reading_ if the script reports
> broken packages. It's all written in the guide, I'm not making it up.

Ah, sorry, I misinterpreted "read on" and think that I should read the reported list and re-emerge broken packages (that surprised me as I got a great list of broken apps and, then, I read the script seeing "Rebuilding" commented part)

Thanks for the explanation