Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 286018 - CVS installs automagic-dependency scripts for csh
Summary: CVS installs automagic-dependency scripts for csh
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-22 20:48 UTC by Jeremy Olexa (darkside) (RETIRED)
Modified: 2009-09-29 18:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to omit csh stuff (cvs-csh.patch,1.13 KB, patch)
2009-09-23 11:12 UTC, Markus Duft (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-09-22 20:48:37 UTC
^[[33;01m*^[[0m home/jolexa/portage/linux-64/usr/share/cvs/contrib/sccs2rcs:/usr/bin/csh
 ^[[31;01m*^[[0m ERROR: dev-util/cvs-1.11.21 failed:
 ^[[31;01m*^[[0m   Aborting due to QA concerns: invalid shebangs found

Gentoo Linux # %% head -n1 /usr/share/cvs/contrib/sccs2rcs
#! no -f

Gentoo Prefix # %% head -n1 usr/share/cvs/contrib/sccs2rcs
#! /usr/bin/csh -f

I can't find a reason why an invalid path got injected...
Comment 1 Fabian Groffen gentoo-dev 2009-09-23 07:35:48 UTC
this is not a false positive, the real problem is in the different shebang
Comment 2 Markus Duft (RETIRED) gentoo-dev 2009-09-23 11:12:36 UTC
Created attachment 205005 [details, diff]
patch to omit csh stuff

cvs configure checks for csh:

...
checking for csh... /usr/bin/csh
...

and subst's @CSH@ into some scripts. so on Gentoo Linux you don't have csh installed, and on Gentoo Prefix that configure scripts finds a non-prefixed csh. so cvs assures that the shebang is ok. however i propose somethings like the attached ebuild patch anyway.
Comment 3 Fabian Groffen gentoo-dev 2009-09-23 11:19:19 UTC
so the configure script basically finds host stuff...

@cvs-utils: what do you think of Markus' patch?
Comment 4 Fabian Groffen gentoo-dev 2009-09-29 18:08:45 UTC
by consensus, let's not bother about this as long as it's not in $PATH.