Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 285989 - app-emacs/gentoo-syntax-1.13: \s causes build to fail with Emacs 22
Summary: app-emacs/gentoo-syntax-1.13: \s causes build to fail with Emacs 22
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2009-09-22 17:43 UTC by Martin von Gagern
Modified: 2009-09-22 20:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix \s in string (285989a.patch,480 bytes, patch)
2009-09-22 17:45 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2009-09-22 17:43:36 UTC
* Emacs version: 22.3.1
>>> Unpacking source...
>>> Unpacking gentoo-syntax-1.13.tar.bz2 to /var/tmp/portage/app-emacs/gentoo-syntax-1.13/work
>>> Source unpacked in /var/tmp/portage/app-emacs/gentoo-syntax-1.13/work
>>> Compiling source in /var/tmp/portage/app-emacs/gentoo-syntax-1.13/work/gentoo-syntax-1.13 ...
 * Compiling GNU Emacs Elisp files ...

In toplevel form:
gentoo-syntax.el:109:1:Error: Invalid modifier in string
 * elisp-compile: batch-byte-compile failed                              [ !! ]
 * 
 * ERROR: app-emacs/gentoo-syntax-1.13 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2493:  Called elisp_src_compile
 *             environment, line  913:  Called die
 * The specific snippet of code:
 *       elisp-compile *.el || die
 *  The die message:
 *   (no error message)

Cause seems to be a "\s" in a string which should be a "\\s" instead. Fixing that issue allowed me to emerge the package successfully. Will attach patch.
Comment 1 Martin von Gagern 2009-09-22 17:45:44 UTC
Created attachment 204950 [details, diff]
Fix \s in string
Comment 2 Ulrich Müller gentoo-dev 2009-09-22 19:29:55 UTC
(In reply to comment #1)
> Created an attachment (id=204950) [edit]
> Fix \s in string

This makes it compile, but it doesn't work.
The following fix should be correct (in SVN r1422):

-             (while (re-search-forward "\\(\s-\\|#\\).*$" nil t)
+             (while (re-search-forward "\\([ \t]\\|#\\).*$" nil t)

Comment 3 Ulrich Müller gentoo-dev 2009-09-22 20:14:45 UTC
Or, even shorter (r1424):

-             (while (re-search-forward "\\(\s-\\|#\\).*$" nil t)
+             (while (re-search-forward "[ \t#].*$" nil t)

Fixed in gentoo-syntax-1.14. Thank you for reporting.