Bug 284433 – xfce4-session-4.6.1 installs fortune-mod which isn't needed to run xfce session

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description rafnov 2009-09-10 08:43:51 UTC]

There's RDEPEND for games-misc/fortune-mod in xfce4-session-4.6.1 ebuild.
I think xfce4-session shouldn't install fortune-mod. Or at least make a USE condision for it.
As explained to me on freenode's #xfce, fortune mod is needed for tips of the day displayed after Xfce starts. I don't need any tips.
Should it be optional?

Reproducible: Always

Steps to Reproduce:
1. emerge -p xfce4-session

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N    ] gnome-base/gnome-common-2.26.0  0 kB
[ebuild  N    ] xfce-base/libxfce4util-4.6.1  USE="-debug" 0 kB
[ebuild  N    ] x11-libs/libwnck-2.26.2-r2  USE="-doc -startup-notification" 0 kB
[ebuild  N    ] games-misc/fortune-mod-1.99.1-r2  USE="-offensive" 0 kB
[ebuild  N    ] dev-perl/glib-perl-1.222  0 kB
[ebuild  N    ] xfce-base/xfconf-4.6.1  USE="perl -debug -profile" 0 kB
[ebuild  N    ] xfce-base/libxfcegui4-4.6.1-r1  USE="-debug -glade -startup-notification" 0 kB
[ebuild  N    ] xfce-base/xfce-utils-4.6.1  USE="lock -dbus -debug" 0 kB
[ebuild  N    ] xfce-base/xfce4-session-4.6.1  USE="-debug -gnome -gnome-keyring -profile" 0 kB


Actual Results:  
games-misc/fortune-mod installed

Expected Results:  
games-misc/fortune-mod excluded from deps

[Comment 1 Samuli Suominen (RETIRED) 2009-09-12 11:41:21 UTC]

So.. I guess someone should try what happens when fortune-mod isn't installed with new user when the startup tip appears.

[Comment 2 rafnov 2009-09-12 13:05:52 UTC]

Afaik Xfce tips will not display fortunes.
From xfce4-session-4.6.1/xfce4-tips/main.c:

  if ((fp = popen(buffer, "r")) == NULL) {                                                                                           
    perror("Unable to execute fortune");                                                                                             
    return;                                                                                                                          
  }

[Comment 3 rafnov 2009-09-12 13:06:50 UTC]

Created attachment 203862 [details]
quick&dirty ebuild that makes fortune-mod installation optional

[Comment 4 Samuli Suominen (RETIRED) 2009-09-13 08:07:05 UTC]

xfce4-tips will print "sh: fortune command not found" on terminal, but nothing else...

dep dropped

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2009-09-13 13:46:04 UTC]

(In reply to comment #4)
> xfce4-tips will print "sh: fortune command not found" on terminal, but nothing
> else...
> 
> dep dropped
> 

I'm not a fan of shipping 90% working packages. As a compromise to support the people that want minimalistic system and people that want 100% working packages, I added this:

+pkg_postinst() {
+       xfconf_pkg_postinst
+       elog "If you would like to see fortunes with xfce4-tips, then install
+       games-misc/fortune-mod"
+}