Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 284244 - www-plugins/gnash-0.8.5: ebuild fails with -nsplugin due to && + || chaining
Summary: www-plugins/gnash-0.8.5: ebuild fails with -nsplugin due to && + || chaining
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Romain Perier (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-09 08:50 UTC by Bernd Feige
Modified: 2009-09-09 10:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2009-09-09 08:50:05 UTC
In src_install(), line 184
use nsplugin && emake DESTDIR="${D}" install-plugin || die "install plugins failed"
always dies with "install plugins failed" if USE=-nsplugin

Reproducible: Always

Steps to Reproduce:
1.emerge gnash

Actual Results:  
"install plugins failed" with no previous error

Expected Results:  
Proceed with installation, merge

Fix:
--- www-plugins/gnash/gnash-0.8.5.ebuild        2009-09-09 07:49:21 +0000
+++ www-plugins/gnash/gnash-0.8.5.ebuild        2009-09-09 07:56:39 +0000
@@ -181,7 +181,9 @@
 src_install() {
        emake ${jobs} DESTDIR="${D}" install || die "emake install failed"
        # Install nsplugin in directory set by --with-npapi-plugindir.
-       use nsplugin && emake DESTDIR="${D}" install-plugin || die "install plugins failed"
+       if use nsplugin; then
+        emake DESTDIR="${D}" install-plugin || die "install plugins failed"
+       fi
 
        # Install kde konqueror plugin.
        if use kde; then
Comment 1 Romain Perier (RETIRED) gentoo-dev 2009-09-09 10:18:37 UTC
+09 Sep 2009; Romain Perier <mrpouet@gentoo.org>
+  gnash-0.8.5.ebuild:
+  Fix bug #284244, src_install() always failed with USE=-nsplugin due to
+  stupid test line 184, replace it by an if.

Fixed into the main tree without a bump, thanks for reporting