Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 28410 - cdrtools-2.01_alpha18-r1.ebuild broken
Summary: cdrtools-2.01_alpha18-r1.ebuild broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Lars Weiler (RETIRED)
URL:
Whiteboard:
Keywords:
: 28450 28476 28477 28488 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-09-10 21:19 UTC by merwan kashouty
Modified: 2011-10-30 22:47 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description merwan kashouty 2003-09-10 21:19:47 UTC
ebuild fails after trying to apply the dvdr patch... if i cp the 16 ebuild
renaming it to 18 it builds successfully... manually aplying the patches adn
running make also works.... so its just  a syntax thing

Reproducible: Always
Steps to Reproduce:
1.emerge cdrtools
2.
3.
Comment 1 Jason Stubbs (RETIRED) gentoo-dev 2003-09-10 22:24:33 UTC
Line 34 of the ebuild has the following line: 
 
        use dvdr && patch -p1 < ../${DVDR_PATCH_P} || die 
 
Without dvdr in the use flags, it obviously dies at this point. Modifying it 
as follows makes it work perfectly. 
 
        use dvdr && (patch -p1 < ../${DVDR_PATCH_P} || die) 
 
Comment 2 SpanKY gentoo-dev 2003-09-11 05:17:14 UTC
you cant subshell in an ebuild, the die command would kill the subshell and not the active one

also, pylon: you should never call patch yourself, use epatch
one of the reasons is this very good example of how you did 'use dvdr && patch || die'
Comment 3 Lars Weiler (RETIRED) gentoo-dev 2003-09-11 07:39:45 UTC
Take my apologies.  I only tested with dvdr in the USE-flags.  For the future I'll test all the USE-flags possibilities.

I changed the line to  use dvdr && epatch ../${DVDR_PATCH_P}
Hope that this is the correct form as I saw in several other ebuilds.

Please let me know if you still have problems.
Comment 4 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-09-11 14:15:46 UTC
*** Bug 28450 has been marked as a duplicate of this bug. ***
Comment 5 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-09-11 14:37:30 UTC
unpack ${DVDR_PATCH_P}.bz2 should also be executed when USE="dvdr", see Bug #28450
Comment 6 Lars Weiler (RETIRED) gentoo-dev 2003-09-11 15:47:05 UTC
I haven't seen that vapier added a "dvdr?" into SRC_URI.  So it's no wonder, when the DVDR-patch can't be found.

Thanks for this hint.

And next time I'll sleep more before editing an ebuild ;)
Comment 7 SpanKY gentoo-dev 2003-09-11 18:01:23 UTC
*** Bug 28476 has been marked as a duplicate of this bug. ***
Comment 8 SpanKY gentoo-dev 2003-09-11 18:01:25 UTC
*** Bug 28477 has been marked as a duplicate of this bug. ***
Comment 9 SpanKY gentoo-dev 2003-09-11 21:18:05 UTC
*** Bug 28488 has been marked as a duplicate of this bug. ***