Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 284073 - www-plugins/gnash-0.8.5 does not build against <xulrunner-1.9.1
Summary: www-plugins/gnash-0.8.5 does not build against <xulrunner-1.9.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Romain Perier (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-08 05:00 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2009-09-09 10:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
gnash-0.8.5-xpcom-idldir.patch (gnash-0.8.5-xpcom-idldir.patch,571 bytes, patch)
2009-09-08 20:33 UTC, Chí-Thanh Christopher Nguyễn 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chí-Thanh Christopher Nguyễn gentoo-dev 2009-09-08 05:00:17 UTC 
Building gnash with USE="nsplugin" against xulrunner-1.9.0 will fail because it looks for nsISupports.idl in /usr/share/idl/xulrunner-1.9/unstable, a directory which only exists since xulrunner-1.9.1.
Previous versions had idl files in /usr/include/xulrunner-1.9/idl/unstable.

Reproducible: Always

Steps to Reproduce:
1. emerge =net-libs/xulrunner-1.9.0*
2. USE="nsplugin" emerge =www-plugins/gnash-0.8.5

Actual Results:  
/usr/lib64/xulrunner-1.9/bin/xpidl -m typelib -v -I/usr/share/idl/xulrunner-1.9/unstable -I/usr/include/nspr iGnashComponent.idl                                                      
/usr/lib64/xulrunner-1.9/bin/xpidl -m header  -v -I/usr/share/idl/xulrunner-1.9/unstable -I/usr/include/nspr iGnashComponent.idl                                                      
./iGnashComponent.idl:19: can't open included file nsISupports.idl for reading             

Expected Results:  
Use idl from /usr/include/xulrunner-1.9/idl/unstable or depend on >=net-libs/xulrunner-1.9.1

This seems to be a regression from gnash-0.8.4
Comment 1 RB 2009-09-08 19:18:35 UTC 
Culprit is macros/xpcom.m4:105, they hard-code the share/idl portion of the path there.
Comment 2 Chí-Thanh Christopher Nguyễn gentoo-dev 2009-09-08 20:33:11 UTC 
Created attachment 203537 [details, diff]
gnash-0.8.5-xpcom-idldir.patch

Use pkgconfig to determine XPCOM_IDL_DIR instead of non-portable construct. Fixes building against xulrunner-1.9.0, thanks to RB for giving the pointer.
Comment 3 Romain Perier (RETIRED) gentoo-dev 2009-09-08 20:43:09 UTC 
@Chi-Thanh: The patch seems to be correct, hey thanks :)

it's cool to help to debug this .... (as you can see yourself) there are some ugly stuffs in their autotools.

Okay, RB could you try this patch ? (with <xulrunner-1.9.1 if possible)
thanks in advance
Comment 4 RB 2009-09-08 22:05:57 UTC 
I can confirm the patch fixes the issue against net-libs/xulrunner-1.9.0.13.
Comment 5 Romain Perier (RETIRED) gentoo-dev 2009-09-09 08:33:51 UTC 
well perfect, I'll commit it :)
Comment 6 Romain Perier (RETIRED) gentoo-dev 2009-09-09 10:36:40 UTC 
+09 Sep 2009; Romain Perier <mrpouet@gentoo.org>
+  gnash-0.8.5.ebuild, +files/gnash-0.8.5-xpcom-idldir.patch:
+  Fix bug #284073, Use pkgconfig to determine XPCOM_IDL_DIR instead of
+  non-portable construct which fix building against xulrunner-1.9.0, many
+  thanks to Chi-Thanh Christopher Nguyen <chithanh@cs.tu-berlin.de>, Add
+  >=sys-devel/libtool-2 in RDEPEND (not portable to libtool-1).

Thanks into the main tree without a bump, many thanks for your help ;)
Comment 7 Romain Perier (RETIRED) gentoo-dev 2009-09-09 10:37:08 UTC 
> Thanks into the main tree without a bump, many thanks for your help ;)
> 

s/Thanks/Fixed/ ;)