Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 283207 - media-sound/rplay fails to compile w/ error: static declaration of 'inetd' follows non-static declaration
Summary: media-sound/rplay fails to compile w/ error: static declaration of 'inetd' fo...
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-30 05:41 UTC by John Moe
Modified: 2009-09-07 13:20 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Moe 2009-08-30 05:41:17 UTC
When emerging rplay, the rplayd program doesn't get built. I'm not sure if this is something Gentoo-specific, or if it needs to be fixed upstream by the rplay devs.  A quick Google on the error given (not rplay specific) seems to say that you need to ensure that you've included string.h in your source (see http://groups.google.com/group/comp.os.msdos.djgpp/browse_thread/thread/3e648eb239aa463a/2334e5cd9485d4b1 and http://gcc.gnu.org/ml/fortran/2005-05/msg00142.html), but I don't know how to do that.  I've included the relevant section of the build log, let me know if you need anything else from me.

Reproducible: Always

Steps to Reproduce:
1. emerge rplay
2. in the section "making all in rplayd" see the error message:
native.c: In function 'zero_native':
native.c:102: warning: incompatible implicit declaration of built-in function 'memset'
3. in the list of files installed, rplayd is not listed
Actual Results:  
No rplayd binary created

Expected Results:  
rplayd compiled and installed

make all in rplayd...
make[1]: Entering directory `/var/tmp/portage/media-sound/rplay-3.3.2/work/rplay-3.3.2/rplayd'
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h audio.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h buffer.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h cache.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h cdrom.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h command.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h connection.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h flange.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h helper.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h host.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h misc.c
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h native.c
native.c: In function 'zero_native':
native.c:102: warning: incompatible implicit declaration of built-in function 'memset'
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h rplayd.c
rplayd.c:189: error: static declaration of 'inetd' follows non-static declaration
rplayd.h:76: error: previous declaration of 'inetd' was here
gcc -c  -I. -I../include -I. -I./../include -I./../lib -I./../adpcm -DHAVE_CONFIG_H -DRPLAY_CONF=\"/etc/rplay.conf\" -DRPLAY_HOSTS=\"/etc/rplay.hosts\" -DRPLAY_SERVERS=\"/etc/rplay.servers\" -DRPLAY_HELPERS=\"/etc/rplay.helpers\" -DRPLAY_CACHE=\"/tmp/.rplay-cache\" -DRPLAY_LOG=\"/tmp/rplay.log\" -DRPLAYDRC=\"\~/.rplaydrc\" -O2 -march=prescott -pipe -include errno.h server.c
make[1]: *** [rplayd.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/media-sound/rplay-3.3.2/work/rplay-3.3.2/rplayd'
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-08-30 12:45:48 UTC
Uhm no the incompatible implicit declaration is not the problem. The problem is this package is incompatible with gcc... 4.1 I think.

I'd say punt...
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-08-30 12:47:58 UTC
fvwm seems to need this…
Comment 3 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-08-30 13:26:48 UTC
(In reply to comment #2)
> fvwm seems to need this…
> 

Not really. It's optional, we would just need to take rid of the rplay
use flag in fvwm, and disable the support for it inconditionaly.

As far as I know, rplay is only used to play system sounds (you know,
when maximizing, minimizing and that kind of useless candy). The fact
is that the same can be achieved using any other players in conjunction
with FvwmEvent (and anyway, you still need FvwmEvent to use rplay, so
rplay virtually doesn't add anything to the fvwm experience).

I know no one using the builtin rplay support in fvwm, and the changes
required in any configuration would be minimal. 

This is as far as my knowledge reaches. However, just for the sake
of correctness, I will ask on the fvwm mailing lists and then I'll
post back here. I will also check if fvwm-themes or fvwm-crystal use
this (though my interest in both of these is zero).

Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-08-30 13:41:38 UTC
The package has been added in 2003 and kept alive till now (even though this is certainly failing with modern gcc)… if fvwm doesn't need it, I'll be happy to kill it.
Comment 5 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-08-30 13:46:33 UTC
(In reply to comment #4)
> The package has been added in 2003 and kept alive till now (even though this is
> certainly failing with modern gcc)… if fvwm doesn't need it, I'll be happy to
> kill it.
> 

I've sent a mail to the list, there's almost always someone looking at that list so I will hopefully get a response soon. I really think that rplay isn't used for anythng besides the system sounds, and as I said, it's not a showstopper, since you can use any other player (mplayer, play from sox, ogg123, mpg123 or whatever suits you). If I am right and that's its only purpose (and I am 99% sure), then I don't even know what the point of integrating rplay in fvwm was at all. But let's way the advice of the fvwm team.

The problem, as I said, is that configs using rplay will need a -trivial- fix, so we need to check fvwm-themes and fvwm-crystal, which are in portage as well. If they use rplay or something, I can surely fix them, though the ideal thing would be to completely remove rplay from fvwm upstream, I am not the first to think about it. I remember some comments on that respect on their mailing list not too long ago. 
Comment 6 Thomas Adam 2009-08-30 15:22:12 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > The package has been added in 2003 and kept alive till now (even though this is
> > certainly failing with modern gcc)… if fvwm doesn't need it, I'll be happy to
> > kill it.
> > 
> 
> I've sent a mail to the list, there's almost always someone looking at that
> list so I will hopefully get a response soon. I really think that rplay isn't
> used for anythng besides the system sounds, and as I said, it's not a
> showstopper, since you can use any other player (mplayer, play from sox,
> ogg123, mpg123 or whatever suits you). If I am right and that's its only
> purpose (and I am 99% sure), then I don't even know what the point of
> integrating rplay in fvwm was at all. But let's way the advice of the fvwm
> team.

Do post my comments on this from fvwm@, please.

-- Thomas Adam
Comment 7 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-08-30 15:37:09 UTC
> 
> Do post my comments on this from fvwm@, please.
> 
> -- Thomas Adam
> 

I'll post the mail, verbatim. So they can get the info from first hand.

====================================================
2009/8/30 Jesús Guerrero <i92guboj@terra.es>:
> Hi,
>
> The fact is that rplay doesn't seem to compile against newer gcc
> versions. I never used rplay for anything, and I think I remember
> some conversation (maybe in this same list or in workers) about
> getting rid of it in fvwm, or maybe it was just a comment, I don't
> really remember.

It was I who suggested something along those lines -- but perhaps more
with an idea of *replacing* it with something like pulseaudio which
has an API anyway, and is currently being championed by more than a
few distros at the moment.

Sounds on events (which is indeed the *only* reason we link against
librplay -- back when it was just FvwmAudio) is akin to the 1995
coolness of "under construction" for webpages; it seems to me a thing
of the past --- and whilst that isn't a reason for getting rid of
functionality, it was always something to bear in mind -- and I *did*
say as much when (IMO, more work than was necessary) FvwmEvent was
changed a lot to support different rplay stuff behind the scenes.

> There's a bug open at bugs.gentoo.org[1] and they are thinking
> about getting rid of rplay. Someone else pointed out the fact that
> fvwm needs it.

So I looked at this bug, and looks simple enough to fix; and I would
be willing to do so since:

1.  Getting it fixed is worthwhile.
2.  Someone should find out if it has an upstream maintainer.
3.  If it turns out this ""bug"" is nothing more than a
compiler-specific idiom for older code, let Gentoo and all the other
distros do what they do best, unofficially patch the hell out of it.
:P

Another thing to bear in mind -- FVWM (unlike most other FOSS projects
these days) *isn't* just running on Linux, it also runs on *BSD,
Solaris, etc., where versions of librplay are still going to be
maintained.   So ripping it out isn't as straight-forward as you might
think.

> My question is this: as far as I know, rplay is used *only* to play
> system sounds via FvwmEvent, is that correct?

See above.

> And second: that same functionality can be reproduced (also using
> FvwmEvent) with virtually any command line player, like play, mpg123
> or whatever. Is there any loss of functionality that I am not aware
> of if we do so instead of using rplay?

The whole point of librplay was so that you didn't need to use
external apps like this, where they were less common on older
installations of UN*X.

> If 1) rplay is only used for system sounds and 2) we can use virtually
> any other player to do the same work in conjunction with FvwmEvent
> then rplay is pointless and fixing it to work with newer gcc versions
> is a waste of time. Please, kindly let me know what do you think about
> this reasoning.

See above.

-- Thomas Adam
====================================================
Comment 8 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-08-30 15:41:17 UTC
I've investigated a bit and I'll just add a couple of things:

-fvwm-themes has a config dialog to chose different sound
 systems, so that's not a problem.
-fvwm-crystal doesn't use rplay for anything as far as I
 can tell.

There's no real showstopper to take rid of rplay if you truly want to, however I have to say also that I've tried compiling it, with gcc-4.4.1 and it worked without a problem. So, I wonder what the true problem is.
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2009-09-07 13:20:39 UTC
Couldn't get 3.3.2 to fail with everything-is-latest toolchain, and...

+*rplay-3.3.2-r1 (07 Sep 2009)
+
+  07 Sep 2009; Samuli Suominen <ssuominen@gentoo.org>
+  +rplay-3.3.2-r1.ebuild:
+  Revision -12 from Debian.